mbox series

[v6,0/3] enable eeprom "size" property and runtime pm

Message ID 1504520928-5191-1-git-send-email-divagar.mohandass@intel.com
Headers show
Series enable eeprom "size" property and runtime pm | expand

Message

Divagar Mohandass Sept. 4, 2017, 10:28 a.m. UTC
This series adds support for eeprom "size" property which will be read by the
driver for eeprom size. The existing ACPI has a different default size which
can be overridden with a DSD property value provided by the platform FW.

This series also adds support for runtime PM. The eeprom driver currently
did not have support for runtime PM and the device was kept in D0 throughout.

[v1]
- Add support for eeprom "size" property.
- Add runtime PM support to the driver.

[v2]
- Improved the patch subject.

[v3]
- Addressed comments from Sakari Ailus.
- Improved patch description.
- Improved pm support patch.

[v4]
- Improved runtime pm support.
- Addressed comments from Sakari Ailus.

[v5]
- Addressed comments from Sakari Ailus.
- Improved error handling for PM support.

[v6]
- Addressed comments from Sakari Ailus.

Divagar Mohandass (3):
  dt-bindings: add eeprom "size" property
  eeprom: at24: add support to fetch eeprom device property "size"
  eeprom: at24: enable runtime pm support

 .../devicetree/bindings/eeprom/eeprom.txt          |  2 ++
 drivers/misc/eeprom/at24.c                         | 42 ++++++++++++++++++++++
 2 files changed, 44 insertions(+)

Comments

Sakari Ailus Sept. 5, 2017, 1:48 p.m. UTC | #1
Hi Divagar,

On Mon, Sep 04, 2017 at 03:58:45PM +0530, Divagar Mohandass wrote:
> This series adds support for eeprom "size" property which will be read by the
> driver for eeprom size. The existing ACPI has a different default size which
> can be overridden with a DSD property value provided by the platform FW.
> 
> This series also adds support for runtime PM. The eeprom driver currently
> did not have support for runtime PM and the device was kept in D0 throughout.
> 
> [v1]
> - Add support for eeprom "size" property.
> - Add runtime PM support to the driver.
> 
> [v2]
> - Improved the patch subject.
> 
> [v3]
> - Addressed comments from Sakari Ailus.
> - Improved patch description.
> - Improved pm support patch.
> 
> [v4]
> - Improved runtime pm support.
> - Addressed comments from Sakari Ailus.
> 
> [v5]
> - Addressed comments from Sakari Ailus.
> - Improved error handling for PM support.
> 
> [v6]
> - Addressed comments from Sakari Ailus.
> 
> Divagar Mohandass (3):
>   dt-bindings: add eeprom "size" property
>   eeprom: at24: add support to fetch eeprom device property "size"
>   eeprom: at24: enable runtime pm support
> 
>  .../devicetree/bindings/eeprom/eeprom.txt          |  2 ++
>  drivers/misc/eeprom/at24.c                         | 42 ++++++++++++++++++++++
>  2 files changed, 44 insertions(+)

Thanks for the update!

For the set:

Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Mani, Rajmohan Sept. 20, 2017, 3:51 a.m. UTC | #2
Adding Tomasz...

> -----Original Message-----
> From: Sakari Ailus [mailto:sakari.ailus@iki.fi]
> Sent: Tuesday, September 05, 2017 6:48 AM
> To: Mohandass, Divagar <divagar.mohandass@intel.com>
> Cc: robh+dt@kernel.org; mark.rutland@arm.com; wsa@the-dreams.de;
> devicetree@vger.kernel.org; linux-i2c@vger.kernel.org; linux-
> kernel@vger.kernel.org; Mani, Rajmohan <rajmohan.mani@intel.com>
> Subject: Re: [PATCH v6 0/3] enable eeprom "size" property and runtime pm
> 
> Hi Divagar,
> 
> On Mon, Sep 04, 2017 at 03:58:45PM +0530, Divagar Mohandass wrote:
> > This series adds support for eeprom "size" property which will be read
> > by the driver for eeprom size. The existing ACPI has a different
> > default size which can be overridden with a DSD property value provided by
> the platform FW.
> >
> > This series also adds support for runtime PM. The eeprom driver
> > currently did not have support for runtime PM and the device was kept in D0
> throughout.
> >
> > [v1]
> > - Add support for eeprom "size" property.
> > - Add runtime PM support to the driver.
> >
> > [v2]
> > - Improved the patch subject.
> >
> > [v3]
> > - Addressed comments from Sakari Ailus.
> > - Improved patch description.
> > - Improved pm support patch.
> >
> > [v4]
> > - Improved runtime pm support.
> > - Addressed comments from Sakari Ailus.
> >
> > [v5]
> > - Addressed comments from Sakari Ailus.
> > - Improved error handling for PM support.
> >
> > [v6]
> > - Addressed comments from Sakari Ailus.
> >
> > Divagar Mohandass (3):
> >   dt-bindings: add eeprom "size" property
> >   eeprom: at24: add support to fetch eeprom device property "size"
> >   eeprom: at24: enable runtime pm support
> >
> >  .../devicetree/bindings/eeprom/eeprom.txt          |  2 ++
> >  drivers/misc/eeprom/at24.c                         | 42 ++++++++++++++++++++++
> >  2 files changed, 44 insertions(+)
> 
> Thanks for the update!
> 
> For the set:
> 
> Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> 
> --
> Kind regards,
> 
> Sakari Ailus
> e-mail: sakari.ailus@iki.fi