mbox series

[SRU,B,0/1] Ubuntu 18.04 - wrong cpu-mf counter number (LP: 1847109)

Message ID 1570538856-28796-1-git-send-email-frank.heimes@canonical.com
Headers show
Series Ubuntu 18.04 - wrong cpu-mf counter number (LP: 1847109) | expand

Message

Frank Heimes Oct. 8, 2019, 12:47 p.m. UTC
Buglink: https://bugs.launchpad.net/bugs/1847109

SRU Justification:

[Impact]

* wrong cpu-mf counter number of LAST_HOST_TRANSLATIONS

[Fix]

* 81507f38d427ebed3291a3c153a798937c998140 81507f38 "s390/cpum_cf: correct counter number of LAST_HOST_TRANSLATIONS"

[Test Case]

* inspect the counter number of the LAST_HOST_TRANSLATIONS (virtual) file

* cat /sys/devices/cpum_cf/events/LAST_HOST_TRANSLATIONS

* returns 'event=0x00e9', but should be 'event=0x00e8'

* event is only available on z14 and higher, hence Canonical can only do regression testing - IBM the functional verification

[Regression Potential] 

* very minimal, patch just changes one hex number in one code line

* change is limited to z14 (and higher) hardware counters only

[Other Info]

* fix/patch got upstream accepted with 4.16

* hence it's already in (cosmic and) disco and eoan and only need to be applied to bionic 4.15

Hendrik Brueckner (1):
  From: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>

 arch/s390/kernel/perf_cpum_cf_events.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kleber Sacilotto de Souza Oct. 16, 2019, 4:01 p.m. UTC | #1
On 08.10.19 14:47, frank.heimes@canonical.com wrote:
> Buglink: https://bugs.launchpad.net/bugs/1847109
> 
> SRU Justification:
> 
> [Impact]
> 
> * wrong cpu-mf counter number of LAST_HOST_TRANSLATIONS
> 
> [Fix]
> 
> * 81507f38d427ebed3291a3c153a798937c998140 81507f38 "s390/cpum_cf: correct counter number of LAST_HOST_TRANSLATIONS"
> 
> [Test Case]
> 
> * inspect the counter number of the LAST_HOST_TRANSLATIONS (virtual) file
> 
> * cat /sys/devices/cpum_cf/events/LAST_HOST_TRANSLATIONS
> 
> * returns 'event=0x00e9', but should be 'event=0x00e8'
> 
> * event is only available on z14 and higher, hence Canonical can only do regression testing - IBM the functional verification
> 
> [Regression Potential] 
> 
> * very minimal, patch just changes one hex number in one code line
> 
> * change is limited to z14 (and higher) hardware counters only
> 
> [Other Info]
> 
> * fix/patch got upstream accepted with 4.16
> 
> * hence it's already in (cosmic and) disco and eoan and only need to be applied to bionic 4.15
> 
> Hendrik Brueckner (1):
>   From: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
> 
>  arch/s390/kernel/perf_cpum_cf_events.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied to bionic/master-next branch.

Thanks,
Kleber