mbox series

[SRU,B/D/E/Unstable,0/2] Fix auto-delink on new ums-realtek devices

Message ID 20190902090421.29841-1-kai.heng.feng@canonical.com
Headers show
Series Fix auto-delink on new ums-realtek devices | expand

Message

Kai-Heng Feng Sept. 2, 2019, 9:04 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1838886

[Impact]
Some ums-realtek card readers may dropped from USB bus after using
ums-realtek driver instead of usb-storage generic driver.

[Fix]
Disable auto-delink on new ums-realtek devices, only whitelist three
oldest IDs.

[Test]
Affected user and myself confirmed disabling auto-delink works.

[Regression Potential]
Minimal. Limited to one specific driver and this also restore the old
behavior.

Kai-Heng Feng (2):
  USB: storage: ums-realtek: Update module parameter description for
    auto_delink_en
  USB: storage: ums-realtek: Whitelist auto-delink support

 drivers/usb/storage/realtek_cr.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

Comments

Seth Forshee Sept. 5, 2019, 8:33 p.m. UTC | #1
On Mon, Sep 02, 2019 at 05:04:19PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1838886
> 
> [Impact]
> Some ums-realtek card readers may dropped from USB bus after using
> ums-realtek driver instead of usb-storage generic driver.
> 
> [Fix]
> Disable auto-delink on new ums-realtek devices, only whitelist three
> oldest IDs.
> 
> [Test]
> Affected user and myself confirmed disabling auto-delink works.
> 
> [Regression Potential]
> Minimal. Limited to one specific driver and this also restore the old
> behavior.

These patches are upstream as of 5.3-rc7, so unstable does not need
them, and the patches can be marked as coming from upstream rather than
linux-next.

Acked-by: Seth Forshee <seth.forshee@canonical.com>

Applied to eoan/master-next, thanks!
Stefan Bader Sept. 25, 2019, 8:23 a.m. UTC | #2
On 02.09.19 11:04, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1838886
> 
> [Impact]
> Some ums-realtek card readers may dropped from USB bus after using
> ums-realtek driver instead of usb-storage generic driver.
> 
> [Fix]
> Disable auto-delink on new ums-realtek devices, only whitelist three
> oldest IDs.
> 
> [Test]
> Affected user and myself confirmed disabling auto-delink works.
> 
> [Regression Potential]
> Minimal. Limited to one specific driver and this also restore the old
> behavior.
> 
> Kai-Heng Feng (2):
>   USB: storage: ums-realtek: Update module parameter description for
>     auto_delink_en
>   USB: storage: ums-realtek: Whitelist auto-delink support
> 
>  drivers/usb/storage/realtek_cr.c | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Kleber Sacilotto de Souza Sept. 27, 2019, 12:42 p.m. UTC | #3
On 02.09.19 11:04, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1838886
> 
> [Impact]
> Some ums-realtek card readers may dropped from USB bus after using
> ums-realtek driver instead of usb-storage generic driver.
> 
> [Fix]
> Disable auto-delink on new ums-realtek devices, only whitelist three
> oldest IDs.
> 
> [Test]
> Affected user and myself confirmed disabling auto-delink works.
> 
> [Regression Potential]
> Minimal. Limited to one specific driver and this also restore the old
> behavior.
> 
> Kai-Heng Feng (2):
>   USB: storage: ums-realtek: Update module parameter description for
>     auto_delink_en
>   USB: storage: ums-realtek: Whitelist auto-delink support
> 
>  drivers/usb/storage/realtek_cr.c | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)
> 

These patches have already been applied to Bionic as part of bug #1843338
(Bionic update: upstream stable patchset 2019-09-09) and to Disco as part
of bug #1843622 (Disco update: upstream stable patchset 2019-09-11).


Thanks,
Kleber