| Message ID | 20190808004314.16433-1-dann.frazier@canonical.com |
|---|---|
| Headers | show |
| Series | Fix regressions introduced by CMA allocation rework | expand |
On Wed, Aug 07, 2019 at 06:43:12PM -0600, dann frazier wrote: > BugLink: https://bugs.launchpad.net/bugs/1839395 > > Clean cherry-picks from upstream. The bug says "regression tested only," so how do we know that these patches fix the issues reported on the bug? Thanks, Seth
On Thu, Aug 8, 2019 at 9:35 AM Seth Forshee <seth.forshee@canonical.com> wrote: > > On Wed, Aug 07, 2019 at 06:43:12PM -0600, dann frazier wrote: > > BugLink: https://bugs.launchpad.net/bugs/1839395 > > > > Clean cherry-picks from upstream. > > The bug says "regression tested only," so how do we know that these > patches fix the issues reported on the bug? hey Seth, I don't directly know, as I don't have the hw in question. I'm just going on the basis of the upstream discussion: https://lkml.org/lkml/2019/7/25/1096 I also don't know if that hw even works w/ Ubuntu - but it seems like other platforms could be impacted as well. Background is, anytime I backport subsystem changes like this to an Ubuntu kernel, I try to watch upstream for "Fixes:" commits that reference them, as those "Fixes" won't come in naturally from stable (the fixed commits aren't in a released kernel yet). My logic here is that these fixes look like the type of changes we would normally pull in from stable, and therefore would normally be candidates for Ubuntu. -dann -dann
On Thu, Aug 08, 2019 at 10:48:14AM -0600, dann frazier wrote: > On Thu, Aug 8, 2019 at 9:35 AM Seth Forshee <seth.forshee@canonical.com> wrote: > > > > On Wed, Aug 07, 2019 at 06:43:12PM -0600, dann frazier wrote: > > > BugLink: https://bugs.launchpad.net/bugs/1839395 > > > > > > Clean cherry-picks from upstream. > > > > The bug says "regression tested only," so how do we know that these > > patches fix the issues reported on the bug? > > hey Seth, > I don't directly know, as I don't have the hw in question. I'm just > going on the basis of the upstream discussion: > https://lkml.org/lkml/2019/7/25/1096 > I also don't know if that hw even works w/ Ubuntu - but it seems like > other platforms could be impacted as well. > > Background is, anytime I backport subsystem changes like this to an > Ubuntu kernel, I try to watch upstream for "Fixes:" commits that > reference them, as those "Fixes" won't come in naturally from stable > (the fixed commits aren't in a released kernel yet). My logic here is > that these fixes look like the type of changes we would normally pull > in from stable, and therefore would normally be candidates for Ubuntu. Okay. I agree that it's a good idea to pull in commits that are fixes for anything we've backported (and I really appreciate the fact that you are keeping an eye out for them). I was just a little confused by that statement in the SRU justification, so thanks for clarifying. Seth
On Wed, Aug 07, 2019 at 06:43:12PM -0600, dann frazier wrote: > BugLink: https://bugs.launchpad.net/bugs/1839395 > > Clean cherry-picks from upstream. Upstream bug fixes which look reasonable and have been regression tested. Acked-by: Seth Forshee <seth.forshee@canonical.com> Applied to eoan/master-next, thanks!
On 8/8/19 2:43 AM, dann frazier wrote: > BugLink: https://bugs.launchpad.net/bugs/1839395 > > Clean cherry-picks from upstream. > > Nicolin Chen (2): > dma-contiguous: do not overwrite align in dma_alloc_contiguous() > dma-contiguous: page-align the size in dma_free_contiguous() > > kernel/dma/contiguous.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
On 2019-08-07 18:43:12 , dann frazier wrote: > BugLink: https://bugs.launchpad.net/bugs/1839395 > > Clean cherry-picks from upstream. > > Nicolin Chen (2): > dma-contiguous: do not overwrite align in dma_alloc_contiguous() > dma-contiguous: page-align the size in dma_free_contiguous() > > kernel/dma/contiguous.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > -- > 2.23.0.rc1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team