diff mbox

[1/2,v2] net/fsl: fix a bug in xgmac_mdio

Message ID 1426503350-23181-1-git-send-email-shh.xie@gmail.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

shaohui xie March 16, 2015, 10:55 a.m. UTC 
From: Shaohui Xie <Shaohui.Xie@freescale.com>

There is a bug in xgmac_wait_until_done() which mdio_stat should be used
instead of mdio_data when checking if busy bit is cleared.

Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
---
changes for v2:
splitted from http://patchwork.ozlabs.org/patch/450392/

 drivers/net/ethernet/freescale/xgmac_mdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller March 16, 2015, 8:28 p.m. UTC | #1 
From: <shh.xie@gmail.com>
Date: Mon, 16 Mar 2015 18:55:50 +0800

> From: Shaohui Xie <Shaohui.Xie@freescale.com>
> 
> There is a bug in xgmac_wait_until_done() which mdio_stat should be used
> instead of mdio_data when checking if busy bit is cleared.
> 
> Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> ---
> changes for v2:
> splitted from http://patchwork.ozlabs.org/patch/450392/

Applied to net-next
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c
index 3a83bc2..5f691f2 100644
--- a/drivers/net/ethernet/freescale/xgmac_mdio.c
+++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
@@ -79,7 +79,7 @@  static int xgmac_wait_until_done(struct device *dev,
 
 	/* Wait till the MDIO write is complete */
 	timeout = TIMEOUT;
-	while ((ioread32be(&regs->mdio_data) & MDIO_DATA_BSY) && timeout) {
+	while ((ioread32be(&regs->mdio_stat) & MDIO_STAT_BSY) && timeout) {
 		cpu_relax();
 		timeout--;
 	}