| Message ID | 1258005528-25383-10-git-send-email-yamahata@valinux.co.jp |
|---|---|
| State | New |
| Headers | show |
On Thu, Nov 12, 2009 at 02:58:37PM +0900, Isaku Yamahata wrote: > This patch removes unnecessary & 0xff in pci_dev_find_by_addr(). > > Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> Acked-by: Michael S. Tsirkin <mst@redhat.com> > --- > hw/pci_host.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/hw/pci_host.c b/hw/pci_host.c > index cd2ceb7..672d173 100644 > --- a/hw/pci_host.c > +++ b/hw/pci_host.c > @@ -42,8 +42,9 @@ do { printf("pci_host_data: " fmt , ## __VA_ARGS__); } while (0) > /* the helper functio to get a PCIDeice* for a given pci address */ > static inline PCIDevice *pci_dev_find_by_addr(PCIBus *bus, uint32_t addr) > { > - uint8_t bus_num = (addr >> 16) & 0xff; > - uint8_t devfn = (addr >> 8) & 0xff; > + uint8_t bus_num = addr >> 16; > + uint8_t devfn = addr >> 8; > + > return pci_find_device(bus, bus_num, PCI_SLOT(devfn), PCI_FUNC(devfn)); > } > > -- > 1.6.0.2
diff --git a/hw/pci_host.c b/hw/pci_host.c index cd2ceb7..672d173 100644 --- a/hw/pci_host.c +++ b/hw/pci_host.c @@ -42,8 +42,9 @@ do { printf("pci_host_data: " fmt , ## __VA_ARGS__); } while (0) /* the helper functio to get a PCIDeice* for a given pci address */ static inline PCIDevice *pci_dev_find_by_addr(PCIBus *bus, uint32_t addr) { - uint8_t bus_num = (addr >> 16) & 0xff; - uint8_t devfn = (addr >> 8) & 0xff; + uint8_t bus_num = addr >> 16; + uint8_t devfn = addr >> 8; + return pci_find_device(bus, bus_num, PCI_SLOT(devfn), PCI_FUNC(devfn)); }
This patch removes unnecessary & 0xff in pci_dev_find_by_addr(). Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> --- hw/pci_host.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)