Message ID | m3my2u0w6f.fsf@intrepid.localdomain |
---|---|
State | Not Applicable |
Delegated to: | David Miller |
Headers | show |
On Wed, Nov 11, 2009 at 12:58:16AM +0100, Krzysztof Halasa wrote: > Tested on IXP425 + CS5536. Well I guess we will find out if it works on the Geode LX + CS5536 and loongson + CS5536 sometime. I don't know why it wouldn't work. > Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl> > > diff --git a/drivers/ata/pata_cs5536.c b/drivers/ata/pata_cs5536.c > index 88a7933..0898213 100644 > --- a/drivers/ata/pata_cs5536.c > +++ b/drivers/ata/pata_cs5536.c > @@ -232,7 +232,7 @@ static struct scsi_host_template cs5536_sht = { > }; > > static struct ata_port_operations cs5536_port_ops = { > - .inherits = &ata_bmdma_port_ops, > + .inherits = &ata_bmdma32_port_ops, > .cable_detect = cs5536_cable_detect, > .set_piomode = cs5536_set_piomode, > .set_dmamode = cs5536_set_dmamode,
On 11/10/2009 06:58 PM, Krzysztof Halasa wrote: > Tested on IXP425 + CS5536. > > Signed-off-by: Krzysztof Hałasa<khc@pm.waw.pl> > > diff --git a/drivers/ata/pata_cs5536.c b/drivers/ata/pata_cs5536.c > index 88a7933..0898213 100644 > --- a/drivers/ata/pata_cs5536.c > +++ b/drivers/ata/pata_cs5536.c > @@ -232,7 +232,7 @@ static struct scsi_host_template cs5536_sht = { > }; > > static struct ata_port_operations cs5536_port_ops = { > - .inherits =&ata_bmdma_port_ops, > + .inherits =&ata_bmdma32_port_ops, > .cable_detect = cs5536_cable_detect, > .set_piomode = cs5536_set_piomode, > .set_dmamode = cs5536_set_dmamode, applied -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Jeff Garzik <jgarzik@pobox.com> writes: > > diff --git a/drivers/ata/pata_cs5536.c b/drivers/ata/pata_cs5536.c > > index 88a7933..0898213 100644 > > --- a/drivers/ata/pata_cs5536.c > > +++ b/drivers/ata/pata_cs5536.c > > @@ -232,7 +232,7 @@ static struct scsi_host_template cs5536_sht = { > > }; > > > > static struct ata_port_operations cs5536_port_ops = { > > - .inherits =&ata_bmdma_port_ops, > > + .inherits =&ata_bmdma32_port_ops, > > .cable_detect = cs5536_cable_detect, > > .set_piomode = cs5536_set_piomode, > > .set_dmamode = cs5536_set_dmamode, > > applied Why not rename ata_bmdma_port_ops as ata_bmdma_port_ops16 for consistency? -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 17 Nov 2009 12:35:50 +0100 Thierry Vignaud <tvignaud@mandriva.com> wrote: > Jeff Garzik <jgarzik@pobox.com> writes: > > > > diff --git a/drivers/ata/pata_cs5536.c b/drivers/ata/pata_cs5536.c > > > index 88a7933..0898213 100644 > > > --- a/drivers/ata/pata_cs5536.c > > > +++ b/drivers/ata/pata_cs5536.c > > > @@ -232,7 +232,7 @@ static struct scsi_host_template cs5536_sht = { > > > }; > > > > > > static struct ata_port_operations cs5536_port_ops = { > > > - .inherits =&ata_bmdma_port_ops, > > > + .inherits =&ata_bmdma32_port_ops, > > > .cable_detect = cs5536_cable_detect, > > > .set_piomode = cs5536_set_piomode, > > > .set_dmamode = cs5536_set_dmamode, > > > > applied > > Why not rename ata_bmdma_port_ops as ata_bmdma_port_ops16 for > consistency? Because 16bit is the normal default for ATA BMDMA, and because its a ton of unneccessary churn ? -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/ata/pata_cs5536.c b/drivers/ata/pata_cs5536.c index 88a7933..0898213 100644 --- a/drivers/ata/pata_cs5536.c +++ b/drivers/ata/pata_cs5536.c @@ -232,7 +232,7 @@ static struct scsi_host_template cs5536_sht = { }; static struct ata_port_operations cs5536_port_ops = { - .inherits = &ata_bmdma_port_ops, + .inherits = &ata_bmdma32_port_ops, .cable_detect = cs5536_cable_detect, .set_piomode = cs5536_set_piomode, .set_dmamode = cs5536_set_dmamode,
Tested on IXP425 + CS5536. Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>