| Message ID | 4ADDFE0C.3020400@gmail.com |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Roel Kluin <roel.kluin@gmail.com> Date: Tue, 20 Oct 2009 20:14:36 +0200 > ether->txirq and ->rxirq are unsigned > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com> platform_get_irq() returns a signed int so the intention is more likely that catching negative value returns was intended. Probably the correct fix is to mark txirq and rxirq as plain 'int'. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Dear sirs, Okay, it is right, thanks all for your help. I will re-fix it later. 2009/10/30, David Miller <davem@davemloft.net>: > From: Roel Kluin <roel.kluin@gmail.com> > Date: Tue, 20 Oct 2009 20:14:36 +0200 > > > ether->txirq and ->rxirq are unsigned > > > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com> > > platform_get_irq() returns a signed int so the intention > is more likely that catching negative value returns > was intended. > > Probably the correct fix is to mark txirq and rxirq as > plain 'int'. >
diff --git a/drivers/net/arm/w90p910_ether.c b/drivers/net/arm/w90p910_ether.c index 25e2627..503c2ce 100644 --- a/drivers/net/arm/w90p910_ether.c +++ b/drivers/net/arm/w90p910_ether.c @@ -981,7 +981,7 @@ static int __devinit w90p910_ether_probe(struct platform_device *pdev) { struct w90p910_ether *ether; struct net_device *dev; - int error; + int error, ret; dev = alloc_etherdev(sizeof(struct w90p910_ether)); if (!dev) @@ -1010,17 +1010,19 @@ static int __devinit w90p910_ether_probe(struct platform_device *pdev) goto failed_free_mem; } - ether->txirq = platform_get_irq(pdev, 0); - if (ether->txirq < 0) { + ret = platform_get_irq(pdev, 0); + ether->txirq = ret; + if (ret < 0) { dev_err(&pdev->dev, "failed to get ether tx irq\n"); - error = -ENXIO; + error = ret; goto failed_free_io; } - ether->rxirq = platform_get_irq(pdev, 1); - if (ether->rxirq < 0) { + ret = platform_get_irq(pdev, 1); + ether->rxirq = ret; + if (ret < 0) { dev_err(&pdev->dev, "failed to get ether rx irq\n"); - error = -ENXIO; + error = ret; goto failed_free_txirq; }
ether->txirq and ->rxirq are unsigned Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html