diff mbox

[tpmdd-devel,01/16] tpm/tpm_i2c_stm_st33: Update Kconfig in order to be inline to other similar product

Message ID 1412712189-1234-2-git-send-email-christophe-h.ricard@st.com
State Superseded, archived
Headers show

Commit Message

Christophe Ricard Oct. 7, 2014, 8:02 p.m. UTC
STMicroelectronics i2c tpm is the only one to have a different tristate
label.

Rename it "TPM Interface Specification 1.2 Interface (I2C - STMicroelectronics)"

Signed-off-by: Christophe Ricard <christophe-h.ricard@st.com>
---
 drivers/char/tpm/Kconfig | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

Comments

Jason Gunthorpe Oct. 7, 2014, 9:40 p.m. UTC | #1
On Tue, Oct 07, 2014 at 10:02:54PM +0200, Christophe Ricard wrote:
> STMicroelectronics i2c tpm is the only one to have a different tristate
> label.
> 
> Rename it "TPM Interface Specification 1.2 Interface (I2C - STMicroelectronics)"

Looks fine, but why move the stanza? Are you sorting on the short
description? (vs config tag?)

Jason

------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
Christophe Ricard Oct. 8, 2014, 5:12 a.m. UTC | #2
Hi Jason,

The goal here is only to uniformize label in Kconfig in order to have 
something similar than:
- |TCG_TIS_I2C_INFINEON
- ||TCG_TIS_I2C_NUVOTON
- ||TCG_TIS_I2C_ATMEL

 From the TPM i2c chip we are the only one to have a different label style.
I agree this is only a sanity patch.

Best Regards
Christophe

|||On 07/10/2014 23:40, Jason Gunthorpe wrote:
> On Tue, Oct 07, 2014 at 10:02:54PM +0200, Christophe Ricard wrote:
>> STMicroelectronics i2c tpm is the only one to have a different tristate
>> label.
>>
>> Rename it "TPM Interface Specification 1.2 Interface (I2C - STMicroelectronics)"
> Looks fine, but why move the stanza? Are you sorting on the short
> description? (vs config tag?)
>
> Jason
------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
diff mbox

Patch

diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index c54cac3..21abb0e 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -63,6 +63,16 @@  config TCG_TIS_I2C_NUVOTON
 	  To compile this driver as a module, choose M here; the module
 	  will be called tpm_i2c_nuvoton.
 
+config TCG_ST33_I2C
+	tristate "TPM Interface Specification 1.2 Interface (I2C - STMicroelectronics)"
+	depends on I2C
+	depends on GPIOLIB
+	---help---
+	  If you have a TPM security chip from STMicroelectronics working with
+	  an I2C bus say Yes and it will be accessible from within Linux.
+	  To compile this driver as a module, choose M here; the module will be
+	  called tpm_stm_st33_i2c.
+
 config TCG_NSC
 	tristate "National Semiconductor TPM Interface"
 	depends on X86
@@ -100,16 +110,6 @@  config TCG_IBMVTPM
 	  will be accessible from within Linux.  To compile this driver
 	  as a module, choose M here; the module will be called tpm_ibmvtpm.
 
-config TCG_ST33_I2C
-	tristate "STMicroelectronics ST33 I2C TPM"
-	depends on I2C
-	depends on GPIOLIB
-	---help---
-	  If you have a TPM security chip from STMicroelectronics working with
-	  an I2C bus say Yes and it will be accessible from within Linux.
-	  To compile this driver as a module, choose M here; the module will be
-	  called tpm_stm_st33_i2c.
-
 config TCG_XEN
 	tristate "XEN TPM Interface"
 	depends on TCG_TPM && XEN