| Message ID | 53C00EF8.1040403@alten.se |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Arvid Brodin <arvid.brodin@alten.se> Date: Fri, 11 Jul 2014 18:21:12 +0200 > MacAddressB is an array (unsigned char MacAddressB[ETH_ALEN]) and is allocated > as a part of *node_dst (which is a struct hsr_node). So the condition is always > false. > > Detected by Dan Carpenter. > > Signed-off-by: Arvid Brodin <arvid.brodin@alten.se> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/hsr/hsr_framereg.c b/net/hsr/hsr_framereg.c index c709c13..bace124 100644 --- a/net/hsr/hsr_framereg.c +++ b/net/hsr/hsr_framereg.c @@ -290,10 +290,6 @@ void hsr_addr_subst_dest(struct hsr_node *node_src, struct sk_buff *skb, } if (port->type != node_dst->AddrB_port) return; - if (!node_dst->MacAddressB) { - WARN_ONCE(1, "%s: No MacAddressB\n", __func__); - return; - } ether_addr_copy(eth_hdr(skb)->h_dest, node_dst->MacAddressB); }
MacAddressB is an array (unsigned char MacAddressB[ETH_ALEN]) and is allocated as a part of *node_dst (which is a struct hsr_node). So the condition is always false. Detected by Dan Carpenter. Signed-off-by: Arvid Brodin <arvid.brodin@alten.se> --- net/hsr/hsr_framereg.c | 4 ---- 1 file changed, 4 deletions(-)