| Message ID | 20140704195746.GA4346@ThinkPad |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Fri, Jul 04, 2014 at 09:57:50PM +0200, Pawel Lebioda wrote: > Hi, > > This patch fixes the following warning reported by checkpatch.pl: > > WARNING: else is not generally useful after a break or return > #235: FILE: drivers/staging/nvec/nvec.c:235: > > Regards > Pawel Lebioda > > Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com> > drivers/staging/nvec/nvec.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Hi Pawel, Please format your patches correctly. There should be no "Hi", no "Regards", etc. After the signed off should be a dashed line. Use git format-patch to format patches and you can send them using git-send-email. See Documentation/SubmittingPatches for more details Thanks,
On Fri, 4 Jul 2014 22:59:41 +0200 Julian Andres Klode <jak@jak-linux.org> wrote: > On Fri, Jul 04, 2014 at 09:57:50PM +0200, Pawel Lebioda wrote: > > Hi, > > > > This patch fixes the following warning reported by checkpatch.pl: > > > > WARNING: else is not generally useful after a break or return > > #235: FILE: drivers/staging/nvec/nvec.c:235: > > > > Regards > > Pawel Lebioda > > > > Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com> > > drivers/staging/nvec/nvec.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > Hi Pawel, > > Please format your patches correctly. There should be no > "Hi", no "Regards", etc. After the signed off should be a > dashed line. > > Use git format-patch to format patches and you can send > them using git-send-email. yes, this way you reduce some apply-burdon from Greg. Ideally, you would combine all patches (one patch per checkpatch warning) in a common thread like this: git-format-patch --cover-letter --thread -s <first commit of your patches> This way you could add some comments (if any) to the cover letter and just keep the plain checkpatch message in the other patches. This has also the advantage that the maintainers only have to ack the "cover letter". Marc
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c index 90f1c4d..8a3dd47 100644 --- a/drivers/staging/nvec/nvec.c +++ b/drivers/staging/nvec/nvec.c @@ -232,8 +232,7 @@ static size_t nvec_msg_size(struct nvec_msg *msg) return 2; else if (event_length == NVEC_3BYTES) return 3; - else - return 0; + return 0; } /**
Hi, This patch fixes the following warning reported by checkpatch.pl: WARNING: else is not generally useful after a break or return #235: FILE: drivers/staging/nvec/nvec.c:235: Regards Pawel Lebioda Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com> drivers/staging/nvec/nvec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html