diff mbox

net: cassini: use nested lock annotation

Message ID 1399590437-5548-1-git-send-email-emilgoode@gmail.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Emil Goode May 8, 2014, 11:07 p.m. UTC
In the cas_lock_tx function we acquire multiple locks in a loop and
need to use nested lock annotation to prevent lockdep warnings.

Reported-by: Meelis Roos <mroos@linux.ee>
Signed-off-by: Emil Goode <emilgoode@gmail.com>
---
 drivers/net/ethernet/sun/cassini.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller May 9, 2014, 8:34 p.m. UTC | #1
From: Emil Goode <emilgoode@gmail.com>
Date: Fri,  9 May 2014 01:07:17 +0200

> In the cas_lock_tx function we acquire multiple locks in a loop and
> need to use nested lock annotation to prevent lockdep warnings.
> 
> Reported-by: Meelis Roos <mroos@linux.ee>
> Signed-off-by: Emil Goode <emilgoode@gmail.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/ethernet/sun/cassini.c b/drivers/net/ethernet/sun/cassini.c
index df8d383..b9ac20f 100644
--- a/drivers/net/ethernet/sun/cassini.c
+++ b/drivers/net/ethernet/sun/cassini.c
@@ -246,7 +246,7 @@  static inline void cas_lock_tx(struct cas *cp)
 	int i;
 
 	for (i = 0; i < N_TX_RINGS; i++)
-		spin_lock(&cp->tx_lock[i]);
+		spin_lock_nested(&cp->tx_lock[i], i);
 }
 
 static inline void cas_lock_all(struct cas *cp)