Message ID | BLU0-SMTP153D21785AACECEDCFB52A977A0@phx.gbl |
---|---|
State | New |
Headers | show |
John David Anglin <dave.anglin@bell.net> writes: > Index: gcc.dg/tree-prof/pr59003.c > =================================================================== > --- gcc.dg/tree-prof/pr59003.c (revision 208769) > +++ gcc.dg/tree-prof/pr59003.c (working copy) > @@ -1,6 +1,7 @@ > /* PR target/59003 */ > /* { dg-options "-O2" } */ > /* { dg-options "-O2 -mtune=amdfam10" { target i?86-*-* x86_64-*-* } } */ > +/* { dg-options "-O2 -fno-common" { target hppa*-*-hpux* } } */ Better handled with dg-additional-options rather than duplicating dg-options. No need to change though, since the x86 entry already used the less preferred style. Rainer
On 3/24/2014 2:48 AM, Rainer Orth wrote: > John David Anglin <dave.anglin@bell.net> writes: > >> Index: gcc.dg/tree-prof/pr59003.c >> =================================================================== >> --- gcc.dg/tree-prof/pr59003.c (revision 208769) >> +++ gcc.dg/tree-prof/pr59003.c (working copy) >> @@ -1,6 +1,7 @@ >> /* PR target/59003 */ >> /* { dg-options "-O2" } */ >> /* { dg-options "-O2 -mtune=amdfam10" { target i?86-*-* x86_64-*-* } } */ >> +/* { dg-options "-O2 -fno-common" { target hppa*-*-hpux* } } */ > Better handled with dg-additional-options rather than duplicating > dg-options. No need to change though, since the x86 entry already used > the less preferred style. I already tried it. dg-additional-options isn't supported in tree-prof. Dave
John David Anglin <dave.anglin@bell.net> writes:
> I already tried it. dg-additional-options isn't supported in tree-prof.
Shouldn't be hard to fix.
Andreas.
John David Anglin <dave.anglin@bell.net> writes: > On 3/24/2014 2:48 AM, Rainer Orth wrote: >> John David Anglin <dave.anglin@bell.net> writes: >> >>> Index: gcc.dg/tree-prof/pr59003.c >>> =================================================================== >>> --- gcc.dg/tree-prof/pr59003.c (revision 208769) >>> +++ gcc.dg/tree-prof/pr59003.c (working copy) >>> @@ -1,6 +1,7 @@ >>> /* PR target/59003 */ >>> /* { dg-options "-O2" } */ >>> /* { dg-options "-O2 -mtune=amdfam10" { target i?86-*-* x86_64-*-* } } */ >>> +/* { dg-options "-O2 -fno-common" { target hppa*-*-hpux* } } */ >> Better handled with dg-additional-options rather than duplicating >> dg-options. No need to change though, since the x86 entry already used >> the less preferred style. > > I already tried it. dg-additional-options isn't supported in tree-prof. It may well be that just accepting it in profopt.exp (and compat.exp and lto.exp and plugin-support.exp that all have copies of that code ;-) works. I'll give it a try. Rainer
Index: gcc.dg/tree-prof/pr59003.c =================================================================== --- gcc.dg/tree-prof/pr59003.c (revision 208769) +++ gcc.dg/tree-prof/pr59003.c (working copy) @@ -1,6 +1,7 @@ /* PR target/59003 */ /* { dg-options "-O2" } */ /* { dg-options "-O2 -mtune=amdfam10" { target i?86-*-* x86_64-*-* } } */ +/* { dg-options "-O2 -fno-common" { target hppa*-*-hpux* } } */ __attribute__((noinline, noclone)) void * foo (void *p, unsigned int q)