Message ID | 20131213163722.498f6e56@nehalam.linuxnetplumber.net |
---|---|
State | Changes Requested, archived |
Delegated to: | David Miller |
Headers | show |
From: Stephen Hemminger <stephen@networkplumber.org> Date: Fri, 13 Dec 2013 16:37:22 -0800 > -void vxlan_get_rx_port(struct net_device *dev) > +static void vxlan_get_rx_port(struct net_device *dev) If you are going to make this static, you need to remove the module symbol export as well. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 13 Dec 2013, Stephen Hemminger wrote: > Make local function static, only used in vxlan itself right now. > Maybe someone had ideas about offload, but they can expose it when > they send their offload upstream. > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > > --- a/drivers/net/vxlan.c 2013-12-12 11:48:17.057855220 -0800 > +++ b/drivers/net/vxlan.c 2013-12-12 11:56:55.949774139 -0800 > @@ -2039,7 +2039,7 @@ static struct device_type vxlan_type = { > * supply the listening VXLAN udp ports. Callers are expected > * to implement the ndo_add_vxlan_port. > */ > -void vxlan_get_rx_port(struct net_device *dev) > +static void vxlan_get_rx_port(struct net_device *dev) > { > struct vxlan_sock *vs; > struct net *net = dev_net(dev); > --- a/include/net/vxlan.h 2013-12-12 11:48:17.057855220 -0800 > +++ b/include/net/vxlan.h 2013-12-12 11:56:55.949774139 -0800 > @@ -41,11 +41,4 @@ __be16 vxlan_src_port(__u16 port_min, __ > /* IPv6 header + UDP + VXLAN + Ethernet header */ > #define VXLAN6_HEADROOM (40 + 8 + 8 + 14) > > -#if IS_ENABLED(CONFIG_VXLAN) > -void vxlan_get_rx_port(struct net_device *netdev); > -#else > -static inline void vxlan_get_rx_port(struct net_device *netdev) > -{ > -} > -#endif > #endif > -- Please do not apply this patch. Jeff Kirsher is about to send a patch that takes advantage of vxlan_get_rx_port in i40e. > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- a/drivers/net/vxlan.c 2013-12-12 11:48:17.057855220 -0800 +++ b/drivers/net/vxlan.c 2013-12-12 11:56:55.949774139 -0800 @@ -2039,7 +2039,7 @@ static struct device_type vxlan_type = { * supply the listening VXLAN udp ports. Callers are expected * to implement the ndo_add_vxlan_port. */ -void vxlan_get_rx_port(struct net_device *dev) +static void vxlan_get_rx_port(struct net_device *dev) { struct vxlan_sock *vs; struct net *net = dev_net(dev); --- a/include/net/vxlan.h 2013-12-12 11:48:17.057855220 -0800 +++ b/include/net/vxlan.h 2013-12-12 11:56:55.949774139 -0800 @@ -41,11 +41,4 @@ __be16 vxlan_src_port(__u16 port_min, __ /* IPv6 header + UDP + VXLAN + Ethernet header */ #define VXLAN6_HEADROOM (40 + 8 + 8 + 14) -#if IS_ENABLED(CONFIG_VXLAN) -void vxlan_get_rx_port(struct net_device *netdev); -#else -static inline void vxlan_get_rx_port(struct net_device *netdev) -{ -} -#endif #endif
Make local function static, only used in vxlan itself right now. Maybe someone had ideas about offload, but they can expose it when they send their offload upstream. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html