| Message ID | 52497B64.3090602@arm.com |
|---|---|
| State | New |
| Headers | show |
On 30/09/13 14:23, Renlin Li wrote: > Hello all, > > Sorry for my last patch that cause some test regressions. I have correct > it, and it has been tested for arm-none-eabi on the model. > > This patch will replace all explicit calls to gen_rtx_PLUS and GEN_INT > with plus_constant. > > OK for trunk? > > Kind regards, > Renlin Li > > gcc/ChangeLog: > > 2013-09-30 Renlin Li <Renlin.Li@arm.com> > > * config/arm/arm.c (arm_output_mi_thunk): Use plus_constant. Looks ok to me but I can't approve it. CC'ing maintainers... Kyrill
On 30 September 2013 14:23, Renlin Li <renlin.li@arm.com> wrote: > OK for trunk? > > Kind regards, > Renlin Li > > gcc/ChangeLog: > > 2013-09-30 Renlin Li <Renlin.Li@arm.com> > > * config/arm/arm.c (arm_output_mi_thunk): Use plus_constant. OK /Marcus
On 01/10/13 11:15, Marcus Shawcroft wrote: > On 30 September 2013 14:23, Renlin Li <renlin.li@arm.com> wrote: > >> OK for trunk? >> >> Kind regards, >> Renlin Li >> >> gcc/ChangeLog: >> >> 2013-09-30 Renlin Li <Renlin.Li@arm.com> >> >> * config/arm/arm.c (arm_output_mi_thunk): Use plus_constant. > OK > /Marcus > Hi Renlin, Richard Earnshaw also ok'd this patch offline. I've committed it for you as r203309. Kyrill
diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c index 2166001..256de81 100644 --- a/gcc/config/arm/arm.c +++ b/gcc/config/arm/arm.c @@ -25352,7 +25352,7 @@ arm_output_mi_thunk (FILE *file, tree thunk ATTRIBUTE_UNUSED, { /* Output ".word .LTHUNKn-7-.LTHUNKPCn". */ rtx tem = XEXP (DECL_RTL (function), 0); - tem = gen_rtx_PLUS (GET_MODE (tem), tem, GEN_INT (-7)); + tem = plus_constant (GET_MODE (tem), tem, -7); tem = gen_rtx_MINUS (GET_MODE (tem), tem, gen_rtx_SYMBOL_REF (Pmode,
Hello all, Sorry for my last patch that cause some test regressions. I have correct it, and it has been tested for arm-none-eabi on the model. This patch will replace all explicit calls to gen_rtx_PLUS and GEN_INT with plus_constant. OK for trunk? Kind regards, Renlin Li gcc/ChangeLog: 2013-09-30 Renlin Li <Renlin.Li@arm.com> * config/arm/arm.c (arm_output_mi_thunk): Use plus_constant.