| Message ID | 20130723161316.10040.78293.stgit@localhost |
|---|---|
| State | Superseded |
| Headers | show |
On Tue, Jul 23, 2013 at 06:13:45PM +0200, Giuseppe Longo wrote: > Signed-off-by: Giuseppe Longo <giuseppelng@gmail.com> > --- > iptables/xtables.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/iptables/xtables.c b/iptables/xtables.c > index d4b8709..d1b04cb 100644 > --- a/iptables/xtables.c > +++ b/iptables/xtables.c > @@ -1096,7 +1096,7 @@ int do_commandx(struct nft_handle *h, int argc, char *argv[], char **table) > if (h->family == AF_UNSPEC) > h->family = args.family; > > - h->ops = nft_family_ops_lookup(args.family); > + h->ops = nft_family_ops_lookup(h->family); Due to lack of patch description, I don't know if you're trying to address a bug or this is just a simple cleanup. > if (h->ops == NULL) > xtables_error(PARAMETER_PROBLEM, "Unknown family"); > > > -- > To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Pablo, >> >- h->ops = nft_family_ops_lookup(args.family); >> >+ h->ops = nft_family_ops_lookup(h->family); > Due to lack of patch description, I don't know if you're trying to > address a bug or this is just a simple cleanup. It's clearly a bug fix here (using args.family forget about if user has used -6) but indeed a one liner description does not harm :) Tomasz -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/iptables/xtables.c b/iptables/xtables.c index d4b8709..d1b04cb 100644 --- a/iptables/xtables.c +++ b/iptables/xtables.c @@ -1096,7 +1096,7 @@ int do_commandx(struct nft_handle *h, int argc, char *argv[], char **table) if (h->family == AF_UNSPEC) h->family = args.family; - h->ops = nft_family_ops_lookup(args.family); + h->ops = nft_family_ops_lookup(h->family); if (h->ops == NULL) xtables_error(PARAMETER_PROBLEM, "Unknown family");
Signed-off-by: Giuseppe Longo <giuseppelng@gmail.com> --- iptables/xtables.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html