| Message ID | 1370542251-27387-5-git-send-email-betty.dall@hp.com |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, 2013-06-06 at 12:10 -0600, Betty Dall wrote: > The function aer_recover_queue() is a public interface and the > severity argument uses #defines that are in the private header > pci/pcie/aer/aerdrv.h. > > This patch moves the #defines from pci/pcie/aer/aerdrv.h to > include/linux/aer.h. [] > diff --git a/include/linux/aer.h b/include/linux/aer.h [] > -extern void cper_print_aer(const char *prefix, struct pci_dev *dev, > +void cper_print_aer(const char *prefix, struct pci_dev *dev, > int cper_severity, struct aer_capability_regs *aer); Can you please also realign the arguments on subsequent lines to the open parenthesis of the first line and reflow then to 80 cols when appropriate? > -extern void aer_recover_queue(int domain, unsigned int bus, unsigned int devfn, > +void aer_recover_queue(int domain, unsigned int bus, unsigned int devfn, > int severity); -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jun 6, 2013 at 12:23 PM, Joe Perches <joe@perches.com> wrote: > On Thu, 2013-06-06 at 12:10 -0600, Betty Dall wrote: >> The function aer_recover_queue() is a public interface and the >> severity argument uses #defines that are in the private header >> pci/pcie/aer/aerdrv.h. >> >> This patch moves the #defines from pci/pcie/aer/aerdrv.h to >> include/linux/aer.h. > [] >> diff --git a/include/linux/aer.h b/include/linux/aer.h > [] >> -extern void cper_print_aer(const char *prefix, struct pci_dev *dev, >> +void cper_print_aer(const char *prefix, struct pci_dev *dev, >> int cper_severity, struct aer_capability_regs *aer); > > Can you please also realign the arguments on subsequent > lines to the open parenthesis of the first line and reflow > then to 80 cols when appropriate? I can do this when I apply them, so don't bother reposting unless you have more substantive changes to make. >> -extern void aer_recover_queue(int domain, unsigned int bus, unsigned int devfn, >> +void aer_recover_queue(int domain, unsigned int bus, unsigned int devfn, >> int severity); > > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday, June 06, 2013 01:28:28 PM Bjorn Helgaas wrote: > On Thu, Jun 6, 2013 at 12:23 PM, Joe Perches <joe@perches.com> wrote: > > On Thu, 2013-06-06 at 12:10 -0600, Betty Dall wrote: > >> The function aer_recover_queue() is a public interface and the > >> severity argument uses #defines that are in the private header > >> pci/pcie/aer/aerdrv.h. > >> > >> This patch moves the #defines from pci/pcie/aer/aerdrv.h to > >> include/linux/aer.h. > > [] > >> diff --git a/include/linux/aer.h b/include/linux/aer.h > > [] > >> -extern void cper_print_aer(const char *prefix, struct pci_dev *dev, > >> +void cper_print_aer(const char *prefix, struct pci_dev *dev, > >> int cper_severity, struct aer_capability_regs *aer); > > > > Can you please also realign the arguments on subsequent > > lines to the open parenthesis of the first line and reflow > > then to 80 cols when appropriate? > > I can do this when I apply them, so don't bother reposting unless you > have more substantive changes to make. For the record, I have no objections against this patchset. Thanks, Rafael
diff --git a/drivers/pci/pcie/aer/aerdrv.h b/drivers/pci/pcie/aer/aerdrv.h index d12c77c..90ea3e8 100644 --- a/drivers/pci/pcie/aer/aerdrv.h +++ b/drivers/pci/pcie/aer/aerdrv.h @@ -13,10 +13,6 @@ #include <linux/aer.h> #include <linux/interrupt.h> -#define AER_NONFATAL 0 -#define AER_FATAL 1 -#define AER_CORRECTABLE 2 - #define SYSTEM_ERROR_INTR_ON_MESG_MASK (PCI_EXP_RTCTL_SECEE| \ PCI_EXP_RTCTL_SENFEE| \ PCI_EXP_RTCTL_SEFEE) diff --git a/include/linux/aer.h b/include/linux/aer.h index ec10e1b..0f6a9e2 100644 --- a/include/linux/aer.h +++ b/include/linux/aer.h @@ -7,6 +7,10 @@ #ifndef _AER_H_ #define _AER_H_ +#define AER_NONFATAL 0 +#define AER_FATAL 1 +#define AER_CORRECTABLE 2 + struct aer_header_log_regs { unsigned int dw0; unsigned int dw1; @@ -31,9 +35,9 @@ struct aer_capability_regs { #if defined(CONFIG_PCIEAER) /* pci-e port driver needs this function to enable aer */ -extern int pci_enable_pcie_error_reporting(struct pci_dev *dev); -extern int pci_disable_pcie_error_reporting(struct pci_dev *dev); -extern int pci_cleanup_aer_uncorrect_error_status(struct pci_dev *dev); +int pci_enable_pcie_error_reporting(struct pci_dev *dev); +int pci_disable_pcie_error_reporting(struct pci_dev *dev); +int pci_cleanup_aer_uncorrect_error_status(struct pci_dev *dev); #else static inline int pci_enable_pcie_error_reporting(struct pci_dev *dev) { @@ -49,10 +53,10 @@ static inline int pci_cleanup_aer_uncorrect_error_status(struct pci_dev *dev) } #endif -extern void cper_print_aer(const char *prefix, struct pci_dev *dev, +void cper_print_aer(const char *prefix, struct pci_dev *dev, int cper_severity, struct aer_capability_regs *aer); -extern int cper_severity_to_aer(int cper_severity); -extern void aer_recover_queue(int domain, unsigned int bus, unsigned int devfn, +int cper_severity_to_aer(int cper_severity); +void aer_recover_queue(int domain, unsigned int bus, unsigned int devfn, int severity); #endif //_AER_H_
The function aer_recover_queue() is a public interface and the severity argument uses #defines that are in the private header pci/pcie/aer/aerdrv.h. This patch moves the #defines from pci/pcie/aer/aerdrv.h to include/linux/aer.h. Signed-off-by: Betty Dall <betty.dall@hp.com> --- drivers/pci/pcie/aer/aerdrv.h | 4 ---- include/linux/aer.h | 16 ++++++++++------ 2 files changed, 10 insertions(+), 10 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html