| Message ID | 1369267057-9371-3-git-send-email-emilio@elopez.com.ar |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Emilio López <emilio@elopez.com.ar> Date: Wed, 22 May 2013 20:57:37 -0300 > Commit bfd428d ("net: ethernet: sun: initialize variables directly") > dropped the only loop that was using i but did not remove the actual > variable, therefore causing a warning when building. This patch drops > the now redundant line. > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Emilio López <emilio@elopez.com.ar> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi David, El 23/05/13 03:43, David Miller escribió: > From: Emilio López <emilio@elopez.com.ar> > Date: Wed, 22 May 2013 20:57:37 -0300 > >> Commit bfd428d ("net: ethernet: sun: initialize variables directly") >> dropped the only loop that was using i but did not remove the actual >> variable, therefore causing a warning when building. This patch drops >> the now redundant line. >> >> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> >> Signed-off-by: Emilio López <emilio@elopez.com.ar> > > Applied. I see that you applied the series in net instead of net-next; the previous patches were in net-next only. This will cause build breakage in net because the loop is still there. Regards, Emilio -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Emilio López <emilio@elopez.com.ar> Date: Thu, 23 May 2013 09:54:23 -0300 > Hi David, > > El 23/05/13 03:43, David Miller escribió: >> From: Emilio López <emilio@elopez.com.ar> >> Date: Wed, 22 May 2013 20:57:37 -0300 >> >>> Commit bfd428d ("net: ethernet: sun: initialize variables directly") >>> dropped the only loop that was using i but did not remove the actual >>> variable, therefore causing a warning when building. This patch drops >>> the now redundant line. >>> >>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> >>> Signed-off-by: Emilio López <emilio@elopez.com.ar> >> >> Applied. > > I see that you applied the series in net instead of net-next; the > previous patches were in net-next only. This will cause build breakage > in net because the loop is still there. My bad, I'll fix this up. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/sun/sunbmac.c b/drivers/net/ethernet/sun/sunbmac.c index 09b4f8c..0d43fa9 100644 --- a/drivers/net/ethernet/sun/sunbmac.c +++ b/drivers/net/ethernet/sun/sunbmac.c @@ -995,7 +995,6 @@ static void bigmac_set_multicast(struct net_device *dev) struct bigmac *bp = netdev_priv(dev); void __iomem *bregs = bp->bregs; struct netdev_hw_addr *ha; - int i; u32 tmp, crc; /* Disable the receiver. The bit self-clears when
Commit bfd428d ("net: ethernet: sun: initialize variables directly") dropped the only loop that was using i but did not remove the actual variable, therefore causing a warning when building. This patch drops the now redundant line. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Emilio López <emilio@elopez.com.ar> --- drivers/net/ethernet/sun/sunbmac.c | 1 - 1 file changed, 1 deletion(-)