Message ID | 1366276658-11938-1-git-send-email-sven@open-mesh.com |
---|---|
State | Rejected, archived |
Delegated to: | David Miller |
Headers | show |
On Thursday 18 April 2013 02:17:38 Sven Eckelmann wrote: > ee07c6e7a6f8a25c18f0a6b18152fbd7499245f6 ("bridge: export multicast database > via netlink") added "struct br_mdb_entry" which includes an element using > the type "struct in6_addr". The file linux/if_bridge.h is part of the uapi > and not defining this type in this file or its includes causes build > failures in userspace applications. It seems this one was already dropped [1]. So, I think it will not be different this time. Just ignore it. Kind regards, Sven [1] http://lkml.indiana.edu/hypermail/linux/kernel/1301.1/03024.html
From: Sven Eckelmann <sven@open-mesh.com> Date: Thu, 18 Apr 2013 11:17:38 +0200 > ee07c6e7a6f8a25c18f0a6b18152fbd7499245f6 ("bridge: export multicast database > via netlink") added "struct br_mdb_entry" which includes an element using the > type "struct in6_addr". The file linux/if_bridge.h is part of the uapi and not > defining this type in this file or its includes causes build failures in > userspace applications. > > Signed-off-by: Sven Eckelmann <sven@open-mesh.com> This will conflict with the in6_addr defined by the libc headers, we're screwed either way here, so we might as well require userspace to include the libc header that defines this type. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/uapi/linux/if_bridge.h b/include/uapi/linux/if_bridge.h index 2d70d79..8e3f287 100644 --- a/include/uapi/linux/if_bridge.h +++ b/include/uapi/linux/if_bridge.h @@ -14,6 +14,7 @@ #define _UAPI_LINUX_IF_BRIDGE_H #include <linux/types.h> +#include <linux/in6.h> #define SYSFS_BRIDGE_ATTR "bridge" #define SYSFS_BRIDGE_FDB "brforward"
ee07c6e7a6f8a25c18f0a6b18152fbd7499245f6 ("bridge: export multicast database via netlink") added "struct br_mdb_entry" which includes an element using the type "struct in6_addr". The file linux/if_bridge.h is part of the uapi and not defining this type in this file or its includes causes build failures in userspace applications. Signed-off-by: Sven Eckelmann <sven@open-mesh.com> --- include/uapi/linux/if_bridge.h | 1 + 1 file changed, 1 insertion(+)