| Message ID | 1365195727-24780-1-git-send-email-minipli@googlemail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Fri, Apr 05, 2013 at 11:02:07PM +0200, Mathias Krause wrote: > Hi Greg, > > I'm unsure if you or Dave should take that one as it's for one a TTY > patch but also living under net/. So I'm uncertain and let you decide! If Dave want to take it, it's fine with me: > -- >8 -- > Subject: [PATCH] TTY: ircomm, use GFP_KERNEL in ircomm_open() > > We're clearly running in non-atomic context as our only call site is > able to call wait_event_interruptible(). So we're safe to use GFP_KERNEL > here instead of GFP_ATOMIC. > > Signed-off-by: Mathias Krause <minipli@googlemail.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Date: Fri, 5 Apr 2013 14:15:00 -0700 > On Fri, Apr 05, 2013 at 11:02:07PM +0200, Mathias Krause wrote: >> Hi Greg, >> >> I'm unsure if you or Dave should take that one as it's for one a TTY >> patch but also living under net/. So I'm uncertain and let you decide! > > If Dave want to take it, it's fine with me: > >> -- >8 -- >> Subject: [PATCH] TTY: ircomm, use GFP_KERNEL in ircomm_open() >> >> We're clearly running in non-atomic context as our only call site is >> able to call wait_event_interruptible(). So we're safe to use GFP_KERNEL >> here instead of GFP_ATOMIC. >> >> Signed-off-by: Mathias Krause <minipli@googlemail.com> > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/irda/ircomm/ircomm_core.c b/net/irda/ircomm/ircomm_core.c index 52079f1..b797daa 100644 --- a/net/irda/ircomm/ircomm_core.c +++ b/net/irda/ircomm/ircomm_core.c @@ -117,7 +117,7 @@ struct ircomm_cb *ircomm_open(notify_t *notify, __u8 service_type, int line) IRDA_ASSERT(ircomm != NULL, return NULL;); - self = kzalloc(sizeof(struct ircomm_cb), GFP_ATOMIC); + self = kzalloc(sizeof(struct ircomm_cb), GFP_KERNEL); if (self == NULL) return NULL;
Hi Greg, I'm unsure if you or Dave should take that one as it's for one a TTY patch but also living under net/. So I'm uncertain and let you decide! Thanks, Mathias -- >8 -- Subject: [PATCH] TTY: ircomm, use GFP_KERNEL in ircomm_open() We're clearly running in non-atomic context as our only call site is able to call wait_event_interruptible(). So we're safe to use GFP_KERNEL here instead of GFP_ATOMIC. Signed-off-by: Mathias Krause <minipli@googlemail.com> --- net/irda/ircomm/ircomm_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)