| Message ID | 1361470206-24116-1-git-send-email-silviupopescu1990@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Thu, 2013-02-21 at 20:10 +0200, Silviu-Mihai Popescu wrote: > This fixes the following sparse warnings: > * net/sunrpc/auth_gss/gss_mech_switch.c:143:21: warning: symbol > '_gss_mech_get_by_name' was not declared. Should it be static? > * net/sunrpc/auth_gss/gss_mech_switch.c:208:21: warning: symbol > '_gss_mech_get_by_pseudoflavor' was not declared. Should it be static? > > Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com> > --- > net/sunrpc/auth_gss/gss_mech_switch.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/sunrpc/auth_gss/gss_mech_switch.c b/net/sunrpc/auth_gss/gss_mech_switch.c > index b174fcd..f0f4eee 100644 > --- a/net/sunrpc/auth_gss/gss_mech_switch.c > +++ b/net/sunrpc/auth_gss/gss_mech_switch.c > @@ -140,7 +140,7 @@ gss_mech_get(struct gss_api_mech *gm) > > EXPORT_SYMBOL_GPL(gss_mech_get); > > -struct gss_api_mech * > +static struct gss_api_mech * > _gss_mech_get_by_name(const char *name) > { > struct gss_api_mech *pos, *gm = NULL; > @@ -205,7 +205,7 @@ mech_supports_pseudoflavor(struct gss_api_mech *gm, u32 pseudoflavor) > return 0; > } > > -struct gss_api_mech *_gss_mech_get_by_pseudoflavor(u32 pseudoflavor) > +static struct gss_api_mech *_gss_mech_get_by_pseudoflavor(u32 pseudoflavor) > { > struct gss_api_mech *gm = NULL, *pos; > This is identical to commit c5f5e9c5d2e9178fb0bfe4f44f0afcc8ad6488ef (SUNRPC: Add missing static declaration to _gss_mech_get_by_name) which is already upstream. Cheers Trond
diff --git a/net/sunrpc/auth_gss/gss_mech_switch.c b/net/sunrpc/auth_gss/gss_mech_switch.c index b174fcd..f0f4eee 100644 --- a/net/sunrpc/auth_gss/gss_mech_switch.c +++ b/net/sunrpc/auth_gss/gss_mech_switch.c @@ -140,7 +140,7 @@ gss_mech_get(struct gss_api_mech *gm) EXPORT_SYMBOL_GPL(gss_mech_get); -struct gss_api_mech * +static struct gss_api_mech * _gss_mech_get_by_name(const char *name) { struct gss_api_mech *pos, *gm = NULL; @@ -205,7 +205,7 @@ mech_supports_pseudoflavor(struct gss_api_mech *gm, u32 pseudoflavor) return 0; } -struct gss_api_mech *_gss_mech_get_by_pseudoflavor(u32 pseudoflavor) +static struct gss_api_mech *_gss_mech_get_by_pseudoflavor(u32 pseudoflavor) { struct gss_api_mech *gm = NULL, *pos;
This fixes the following sparse warnings: * net/sunrpc/auth_gss/gss_mech_switch.c:143:21: warning: symbol '_gss_mech_get_by_name' was not declared. Should it be static? * net/sunrpc/auth_gss/gss_mech_switch.c:208:21: warning: symbol '_gss_mech_get_by_pseudoflavor' was not declared. Should it be static? Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com> --- net/sunrpc/auth_gss/gss_mech_switch.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)