diff mbox

to fix : crosstool-NG-1.18.0 - obsolete RPC headers are not installed for Glibc

Message ID CAFKqv7w8HVnA2RRS7sGn4=iMnnw+HPEEpNq1_-JEko_TaMf4jw@mail.gmail.com
State Changes Requested
Headers show

Commit Message

Jérôme BARDON Feb. 15, 2013, 2:43 p.m. UTC 
Here is a patch to fix this :
==============================================================

Regards,

Jérôme BARDON
Thomson Video Networks


2013/2/15 Jérôme BARDON <bardon.pro@gmail.com>:
> Hi,
>
> In crosstool-NG-1.18.0 the obsolete RPC headers (installed with the
> --enable-obsolete-rpc option) are only installed for eGlibc.
>
> This is a problem for me as my rootfs needs RPC and Glibc.
>
>
> Jérôme BARDON
> Thomson Video Networks

--
For unsubscribe information see http://sourceware.org/lists.html#faq

Comments

Yann E. MORIN Feb. 15, 2013, 6:03 p.m. UTC | #1 
Jérôme, All,

On Friday 15 February 2013 Jérôme BARDON wrote:
> Here is a patch to fix this :
> ================================================================
> # HG changeset patch
> # User Jerome BARDON <bardon.pro@gmail.com>
> # Date 1360923357 -3600
> # Node ID 367d677bfbeee5905310cbf0bf4636f76a786192
> # Parent  fb662f18d002da9303aba2ea933c5204b789e752
> also add RPC headers install for Glibc

The commit log should be a bit more explicit about what the changeset is
about (basically, what you added below the patch), and must include your
SoB-line (see: http://www.elinux.org/Developer_Certificate_Of_Origin ),
something like:

    libc/glibc: install obsolete RPC for both eglibc and glibc

    Currently, the obsolete RPC headers are only installed for eglibc,
    but glibc has the same /deficiency/, so install the obsolete RPC
    for both.

    Signed-off-by: Your Real Name <a.valid@email.address>

> diff -r fb662f18d002 -r 367d677bfbee scripts/build/libc/glibc-eglibc.sh-common
> --- a/scripts/build/libc/glibc-eglibc.sh-common Fri Feb 15 10:46:40 2013 +0100
> +++ b/scripts/build/libc/glibc-eglibc.sh-common Fri Feb 15 11:15:57 2013 +0100
> @@ -222,7 +222,9 @@
>              OPTIMIZE=-O2
>              # Also, if those two are missing, iconv build breaks
>              extra_config+=( --disable-debug --disable-sanity-checks )
> -            ;;
> +            # always include rpc, the user can still override it with TI-RPC
> +            extra_config+=( --enable-obsolete-rpc )
> +             ;;
>      esac

Rather than duplicate the code in both the glibc and the eglibc path, just
move the existing "extra_config+=" line just belose the "esac".

Thank you! :-)

Regards,
Yann E. MORIN.
diff mbox

Patch

================================================================
# HG changeset patch
# User Jerome BARDON <bardon.pro@gmail.com>
# Date 1360923357 -3600
# Node ID 367d677bfbeee5905310cbf0bf4636f76a786192
# Parent  fb662f18d002da9303aba2ea933c5204b789e752
also add RPC headers install for Glibc

diff -r fb662f18d002 -r 367d677bfbee scripts/build/libc/glibc-eglibc.sh-common
--- a/scripts/build/libc/glibc-eglibc.sh-common Fri Feb 15 10:46:40 2013 +0100
+++ b/scripts/build/libc/glibc-eglibc.sh-common Fri Feb 15 11:15:57 2013 +0100
@@ -222,7 +222,9 @@ 
             OPTIMIZE=-O2
             # Also, if those two are missing, iconv build breaks
             extra_config+=( --disable-debug --disable-sanity-checks )
-            ;;
+            # always include rpc, the user can still override it with TI-RPC
+            extra_config+=( --enable-obsolete-rpc )
+             ;;
     esac

     # Add some default glibc config options if not given by user.