Message ID | alpine.DEB.2.00.1301260754500.19277@utopia.booyaka.com |
---|---|
State | New, archived |
Headers | show |
On Sat, 2013-01-26 at 07:56 +0000, Paul Walmsley wrote: > Hi Artem, David, > > if possible, it would be good to get this one into v3.8-rc, due to the > large OMAP boot-time warning mentioned at: > > http://article.gmane.org/gmane.linux.ports.arm.omap/91317 It is in David's tree, he merges things upstream, I do not know about his plans WRT this patch, unfortunately.
On Mon, Feb 4, 2013 at 12:39 AM, Artem Bityutskiy <dedekind1@gmail.com> wrote: > On Sat, 2013-01-26 at 07:56 +0000, Paul Walmsley wrote: >> Hi Artem, David, >> >> if possible, it would be good to get this one into v3.8-rc, due to the >> large OMAP boot-time warning mentioned at: >> >> http://article.gmane.org/gmane.linux.ports.arm.omap/91317 > > It is in David's tree, he merges things upstream, I do not know about > his plans WRT this patch, unfortunately. It was merged for 3.8-rc7, FYI. Brian
On Sun, 10 Feb 2013, Brian Norris wrote: > On Mon, Feb 4, 2013 at 12:39 AM, Artem Bityutskiy <dedekind1@gmail.com> wrote: > > On Sat, 2013-01-26 at 07:56 +0000, Paul Walmsley wrote: > >> Hi Artem, David, > >> > >> if possible, it would be good to get this one into v3.8-rc, due to the > >> large OMAP boot-time warning mentioned at: > >> > >> http://article.gmane.org/gmane.linux.ports.arm.omap/91317 > > > > It is in David's tree, he merges things upstream, I do not know about > > his plans WRT this patch, unfortunately. > > It was merged for 3.8-rc7, FYI. Thanks, things are much better now in v3.8-rc7. - Paul
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c index 8323ac9..3766682 100644 --- a/drivers/mtd/nand/nand_base.c +++ b/drivers/mtd/nand/nand_base.c @@ -2857,8 +2857,11 @@ static int nand_flash_detect_onfi(struct mtd_info *mtd, struct nand_chip *chip, int i; int val; - /* ONFI need to be probed in 8 bits mode */ - WARN_ON(chip->options & NAND_BUSWIDTH_16); + /* ONFI need to be probed in 8 bits mode, and 16 bits should be selected with NAND_BUSWIDTH_AUTO */ + if (chip->options & NAND_BUSWIDTH_16) { + pr_err("Trying ONFI probe in 16 bits mode, aborting !\n"); + return 0; + } /* Try ONFI for unknown chip or LP */ chip->cmdfunc(mtd, NAND_CMD_READID, 0x20, -1); if (chip->read_byte(mtd) != 'O' || chip->read_byte(mtd) != 'N' ||