Message ID | 1359489540-14620-1-git-send-email-milos.vyletel@sde.cz |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Milos Vyletel <milos.vyletel@sde.cz> Date: Tue, 29 Jan 2013 14:59:00 -0500 > When bonding module is loaded with primary parameter and one decides to unset > primary slave using sysfs these settings are not preserved during bond device > restart. Primary slave is only unset once and it's not remembered in > bond->params structure. Below is example of recreation. ... > > Reviewed-by: Jiri Pirko <jiri@resnulli.us> > Signed-off-by: Milos Vyletel <milos.vyletel@sde.cz> > Signed-off-by: Jay Vosburgh <fubar@us.ibm.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/bond_sysfs.c index ef8d2a0..155f3b4 100644 --- a/drivers/net/bonding/bond_sysfs.c +++ b/drivers/net/bonding/bond_sysfs.c @@ -1067,6 +1067,7 @@ static ssize_t bonding_store_primary(struct device *d, pr_info("%s: Setting primary slave to None.\n", bond->dev->name); bond->primary_slave = NULL; + memset(bond->params.primary, 0, sizeof(bond->params.primary)); bond_select_active_slave(bond); goto out; }