| Message ID | 201301252345.25829.arnd@arndb.de |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Fri, Jan 25, 2013 at 11:45:25PM +0000, Arnd Bergmann wrote: > On Friday 25 January 2013, Myklebust, Trond wrote: > > > -----Original Message----- > > > From: Arnd Bergmann [mailto:arnd@arndb.de] > > > Marking it as __maybe_unused avoids a harmless gcc warning. > > > > Alternatively, just declare it using the RPC_IFDEBUG() macro. > > Right, makes sense: that's more consistent with other functions > doing the same thing. Thanks for taking a look. NAK. There is already a fix queued up as a result of a previous report I sent, but for some reason (which I didn't question) it was decided not to queue it for -rc. See Bruce's reply on lkml: 20130108212816.GA24572@fieldses.org -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Saturday 26 January 2013, Russell King - ARM Linux wrote: > On Fri, Jan 25, 2013 at 11:45:25PM +0000, Arnd Bergmann wrote: > > On Friday 25 January 2013, Myklebust, Trond wrote: > > > > -----Original Message----- > > > > From: Arnd Bergmann [mailto:arnd@arndb.de] > > > > Marking it as __maybe_unused avoids a harmless gcc warning. > > > > > > Alternatively, just declare it using the RPC_IFDEBUG() macro. > > > > Right, makes sense: that's more consistent with other functions > > doing the same thing. Thanks for taking a look. > > NAK. > > There is already a fix queued up as a result of a previous report I > sent, but for some reason (which I didn't question) it was decided > not to queue it for -rc. > > See Bruce's reply on lkml: 20130108212816.GA24572@fieldses.org Ok, makes sense. Then again, if that fix is queued for 3.9, maybe it still makes sense to take the simpler fix into 3.8, and remove it in 3.9 along with the other instances of RPC_IFDEBUG. Arnd -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Jan 26, 2013 at 01:34:56PM +0000, Arnd Bergmann wrote: > On Saturday 26 January 2013, Russell King - ARM Linux wrote: > > On Fri, Jan 25, 2013 at 11:45:25PM +0000, Arnd Bergmann wrote: > > > On Friday 25 January 2013, Myklebust, Trond wrote: > > > > > -----Original Message----- > > > > > From: Arnd Bergmann [mailto:arnd@arndb.de] > > > > > Marking it as __maybe_unused avoids a harmless gcc warning. > > > > > > > > Alternatively, just declare it using the RPC_IFDEBUG() macro. > > > > > > Right, makes sense: that's more consistent with other functions > > > doing the same thing. Thanks for taking a look. > > > > NAK. > > > > There is already a fix queued up as a result of a previous report I > > sent, but for some reason (which I didn't question) it was decided > > not to queue it for -rc. > > > > See Bruce's reply on lkml: 20130108212816.GA24572@fieldses.org Apologies, I've seen so many "stop sending me post-rc1 patches that don't fix serious crashes!" flames. I guess obviousl compile fixes should be an exception--if nothing else it'd save a lot of duplicated work as this is something like the 3rd patch I've seen for this. --b. > > Ok, makes sense. Then again, if that fix is queued for 3.9, maybe > it still makes sense to take the simpler fix into 3.8, and remove > it in 3.9 along with the other instances of RPC_IFDEBUG. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c index dbf12ac..9485e66 100644 --- a/net/sunrpc/svc.c +++ b/net/sunrpc/svc.c @@ -1047,7 +1047,7 @@ void svc_printk(struct svc_rqst *rqstp, const char *fmt, ...) { struct va_format vaf; va_list args; - char buf[RPC_MAX_ADDRBUFLEN]; + RPC_IFDEBUG(char buf[RPC_MAX_ADDRBUFLEN]); va_start(args, fmt);