| Message ID | 49744AE6.9@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Roel Kluin <roel.kluin@gmail.com> Date: Mon, 19 Jan 2009 10:41:58 +0100 > David Miller wrote: > > From: Roel Kluin <roel.kluin@gmail.com> > > Date: Sun, 18 Jan 2009 23:57:43 +0100 > > > >> both pdata->mdc and pdata->mdio are unsigned. Notice a negative > >> return value. > > > > You left the unsigned tests in there: > > > >> if (pdata->mdc < 0 || pdata->mdio < 0) > >> goto out_free; > > > > Please remove them. > > thanks, here it is, also with a signoff: > > both pdata->mdc and pdata->mdio are unsigned. Notice a negative > return value. > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Applied, thanks Roel. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-gpio.c index a439ebe..3f460c5 100644 --- a/drivers/net/phy/mdio-gpio.c +++ b/drivers/net/phy/mdio-gpio.c @@ -200,16 +200,21 @@ static int __devinit mdio_ofgpio_probe(struct of_device *ofdev, { struct device_node *np = NULL; struct mdio_gpio_platform_data *pdata; + int ret; pdata = kzalloc(sizeof(*pdata), GFP_KERNEL); if (!pdata) return -ENOMEM; - pdata->mdc = of_get_gpio(ofdev->node, 0); - pdata->mdio = of_get_gpio(ofdev->node, 1); - - if (pdata->mdc < 0 || pdata->mdio < 0) + ret = of_get_gpio(ofdev->node, 0); + if (ret < 0) goto out_free; + pdata->mdc = ret; + + ret = of_get_gpio(ofdev->node, 1); + if (ret < 0) + goto out_free; + pdata->mdio = ret; while ((np = of_get_next_child(ofdev->node, np))) if (!strcmp(np->type, "ethernet-phy"))