| Message ID | 20121113082615.2f482eb8835daf46e1f27947@canb.auug.org.au |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Tue, 13 Nov 2012 08:26:15 +1100 > Make if easier for more architectures to select it and thus disable > drivers that use virt_to_bus(). > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> Acked-by: David S. Miller <davem@davemloft.net> -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 12/11/12 21:26, Stephen Rothwell wrote: > Make if easier for more architectures to select it and thus > disable drivers that use virt_to_bus(). > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> Reviewed-by: James Hogan <james.hogan@imgtec.com> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJQohD8AAoJEKHZs+irPybf82gP/Az9f+Q5Vn/fGkQwOOpfsxsl hpZGzIc7P6/ZU6IFWxN8hAKdJjOBH/ko0r+LMoczlQzlhlFd+qpDU+i2tZBqbp/G S+4w56J/PC5MtZFlUEh68e0H313Mgt9kK8vy4yVnzBTvIgGsJuXjeK4qQSKBm3LP LguU2AONT8GCfT8DRm9sbdS+WcXnBjRWeUkm8pZ+UX8kEe7ryaccidwvR16aP9l1 zx4HwFW0nCLYxwSOVQg2hi2pQyHD5sqFeLEYNbvEPlGleRKNJtz3bnYWbRdPkO2D CoRjiSw5/iCd/SghvwEKdkJFkOw4zdONElrBvsYXqn3QsFFpyYal43gyKIgPkSb6 s5OdTJ1ScS3IgtxFpQ1nfj020rS1ieM8eY/bXyuGPEZzwbe0moe+g64Qye9nEutn 7oWKoue1H8uRaJ46WoD22bjG7SezLycDnAlG6ujo75qyxeBcVJ9ZB6DxHPnEU02M P0sA8FLTFmzigRV2TBKBZbh3NrFGEi/riMA8U9f9XfLkxt7zdXGTvJ45C91U8HjT 3uQffRL/WBOQOILXtEFzf22DSPeoRklvyZmlHBsmNC6AYhSDnOvpUfOThaetQaFe voiFdDZhtxdk20l0DpReeAUBVUFOjBjh6NzWLZbVdrfgHrpndw7s7jjfy/e5vhDU wI2jW7slxuwARtv3Q1CV =XvmD -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Nov 12, 2012 at 10:26 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote: > diff --git a/arch/Kconfig b/arch/Kconfig > index 366ec06..9bc00e7 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -271,6 +271,13 @@ config ARCH_WANT_OLD_COMPAT_IPC > select ARCH_WANT_COMPAT_IPC_PARSE_VERSION > bool > > +config ARCH_NO_VIRT_TO_BUS > + bool > + help > + An architecture should select this if it cannot (or will not) > + implement virt_to_bus(). All new architectures should probably > + select this. Don't we typically put the burden of selecting Kconfig flags for deprecated features on the existing architectures that provide the deprecated features? I.e. shouldn't it be ARCH_HAS_VIRT_TO_BUS, selected by the architectures that need it, instead? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Monday 12 November 2012, Stephen Rothwell wrote: > Show Details > Make if easier for more architectures to select it and thus disable > drivers that use virt_to_bus(). > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> Very nice, I was recently looking into enabling this for ARM as well, at least for the platforms that are known to not need virt_to_bus. Acked-by: Arnd Bergmann <arnd@arndb.de> -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Nov 13, 2012 at 3:32 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Mon, Nov 12, 2012 at 10:26 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote: >> diff --git a/arch/Kconfig b/arch/Kconfig >> index 366ec06..9bc00e7 100644 >> --- a/arch/Kconfig >> +++ b/arch/Kconfig >> @@ -271,6 +271,13 @@ config ARCH_WANT_OLD_COMPAT_IPC >> select ARCH_WANT_COMPAT_IPC_PARSE_VERSION >> bool >> >> +config ARCH_NO_VIRT_TO_BUS >> + bool >> + help >> + An architecture should select this if it cannot (or will not) >> + implement virt_to_bus(). All new architectures should probably >> + select this. > > Don't we typically put the burden of selecting Kconfig flags for deprecated > features on the existing architectures that provide the deprecated features? > > I.e. shouldn't it be ARCH_HAS_VIRT_TO_BUS, selected by the architectures > that need it, instead? I like this idea. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Stephen, On 12/11/12 21:26, Stephen Rothwell wrote: > Make if easier for more architectures to select it and thus disable > drivers that use virt_to_bus(). > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> I was just wondering what the status of this patch is? It was in -next for a while but seems to have disappeared. Cheers James
Hi James, On Mon, 11 Feb 2013 11:57:28 +0000 James Hogan <james.hogan@imgtec.com> wrote: > > On 12/11/12 21:26, Stephen Rothwell wrote: > > Make if easier for more architectures to select it and thus disable > > drivers that use virt_to_bus(). > > > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> > > I was just wondering what the status of this patch is? It was in -next > for a while but seems to have disappeared. Yeah, I think Andrew dropped it in favour of a more complete solution which I haven't written yet. Let me dig out the emails and have a shot.
diff --git a/arch/Kconfig b/arch/Kconfig index 366ec06..9bc00e7 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -271,6 +271,13 @@ config ARCH_WANT_OLD_COMPAT_IPC select ARCH_WANT_COMPAT_IPC_PARSE_VERSION bool +config ARCH_NO_VIRT_TO_BUS + bool + help + An architecture should select this if it cannot (or will not) + implement virt_to_bus(). All new architectures should probably + select this. + config GENERIC_KERNEL_THREAD bool diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index a902a5c..8c8fcba 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -87,9 +87,6 @@ config GENERIC_GPIO help Generic GPIO API support -config ARCH_NO_VIRT_TO_BUS - def_bool PPC64 - config PPC bool default y @@ -101,6 +98,7 @@ config PPC select HAVE_FUNCTION_GRAPH_TRACER select SYSCTL_EXCEPTION_TRACE select ARCH_WANT_OPTIONAL_GPIOLIB + select ARCH_NO_VIRT_TO_BUS if PPC64 select HAVE_IDE select HAVE_IOREMAP_PROT select HAVE_EFFICIENT_UNALIGNED_ACCESS diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig index babc2b8..9b28793 100644 --- a/arch/sh/Kconfig +++ b/arch/sh/Kconfig @@ -16,6 +16,7 @@ config SUPERH select HAVE_DEBUG_BUGVERBOSE select ARCH_HAVE_CUSTOM_GPIO_H select ARCH_HAVE_NMI_SAFE_CMPXCHG if (GUSA_RB || CPU_SH4A) + select ARCH_NO_VIRT_TO_BUS select PERF_USE_VMALLOC select HAVE_DEBUG_KMEMLEAK select HAVE_KERNEL_GZIP @@ -150,9 +151,6 @@ config ARCH_HAS_ILOG2_U32 config ARCH_HAS_ILOG2_U64 def_bool n -config ARCH_NO_VIRT_TO_BUS - def_bool y - config ARCH_HAS_DEFAULT_IDLE def_bool y diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig index 9f2edb5..594d9bc 100644 --- a/arch/sparc/Kconfig +++ b/arch/sparc/Kconfig @@ -21,6 +21,7 @@ config SPARC select SYSCTL_EXCEPTION_TRACE select ARCH_WANT_OPTIONAL_GPIOLIB select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE + select ARCH_NO_VIRT_TO_BUS select RTC_CLASS select RTC_DRV_M48T59 select HAVE_IRQ_WORK @@ -143,9 +144,6 @@ config GENERIC_GPIO help Generic GPIO API support -config ARCH_NO_VIRT_TO_BUS - def_bool y - config ARCH_SUPPORTS_DEBUG_PAGEALLOC def_bool y if SPARC64
Make if easier for more architectures to select it and thus disable drivers that use virt_to_bus(). Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> --- arch/Kconfig | 7 +++++++ arch/powerpc/Kconfig | 4 +--- arch/sh/Kconfig | 4 +--- arch/sparc/Kconfig | 4 +--- 4 files changed, 10 insertions(+), 9 deletions(-)