| Message ID | 1347662469-1604-1-git-send-email-peterhuewe@gmx.de |
|---|---|
| State | Accepted |
| Commit | e5570f0c873e3be68a66b479308f21d2dc280a1c |
| Headers | show |
Acked-by: Mike Dunn <mikedunn@newsguy.com> Sorry for the oversight. Mike On 09/14/2012 03:41 PM, Peter Huewe wrote: > While building an allyesconfig for UML I received this error message(s): > drivers/mtd/nand/docg4.c: In function 'probe_docg4': > drivers/mtd/nand/docg4.c:1272:2: error: implicit declaration of function > 'ioremap' [-Werror=implicit-function-declaration] > drivers/mtd/nand/docg4.c:1272:10: warning: assignment makes pointer from > integer without a cast [enabled by default] > drivers/mtd/nand/docg4.c:1327:2: error: implicit declaration of function > 'iounmap' [-Werror=implicit-function-declaration] > > which is caused by the missing implementations on UML. > > This patch adds this missing HAS_IOMEM dependency and prevents the driver from > being build on platforms with no HAS_IOMEM > > Signed-off-by: Peter Huewe <peterhuewe@gmx.de> > --- > drivers/mtd/nand/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > index 8ca4176..3e2f75d 100644 > --- a/drivers/mtd/nand/Kconfig > +++ b/drivers/mtd/nand/Kconfig > @@ -356,7 +356,7 @@ config MTD_NAND_DISKONCHIP_BBTWRITE > > config MTD_NAND_DOCG4 > tristate "Support for DiskOnChip G4 (EXPERIMENTAL)" > - depends on EXPERIMENTAL > + depends on EXPERIMENTAL && HAS_IOMEM > select BCH > select BITREVERSE > help
On Sat, 2012-09-15 at 00:41 +0200, Peter Huewe wrote: > While building an allyesconfig for UML I received this error message(s): > drivers/mtd/nand/docg4.c: In function 'probe_docg4': > drivers/mtd/nand/docg4.c:1272:2: error: implicit declaration of function > 'ioremap' [-Werror=implicit-function-declaration] > drivers/mtd/nand/docg4.c:1272:10: warning: assignment makes pointer from > integer without a cast [enabled by default] > drivers/mtd/nand/docg4.c:1327:2: error: implicit declaration of function > 'iounmap' [-Werror=implicit-function-declaration] Pushed to l2-mtd.git, thanks!
diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig index 8ca4176..3e2f75d 100644 --- a/drivers/mtd/nand/Kconfig +++ b/drivers/mtd/nand/Kconfig @@ -356,7 +356,7 @@ config MTD_NAND_DISKONCHIP_BBTWRITE config MTD_NAND_DOCG4 tristate "Support for DiskOnChip G4 (EXPERIMENTAL)" - depends on EXPERIMENTAL + depends on EXPERIMENTAL && HAS_IOMEM select BCH select BITREVERSE help
While building an allyesconfig for UML I received this error message(s): drivers/mtd/nand/docg4.c: In function 'probe_docg4': drivers/mtd/nand/docg4.c:1272:2: error: implicit declaration of function 'ioremap' [-Werror=implicit-function-declaration] drivers/mtd/nand/docg4.c:1272:10: warning: assignment makes pointer from integer without a cast [enabled by default] drivers/mtd/nand/docg4.c:1327:2: error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration] which is caused by the missing implementations on UML. This patch adds this missing HAS_IOMEM dependency and prevents the driver from being build on platforms with no HAS_IOMEM Signed-off-by: Peter Huewe <peterhuewe@gmx.de> --- drivers/mtd/nand/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)