| Message ID | 05be01cd9527$b35c3480$1a149d80$%kim@samsung.com |
|---|---|
| State | New |
| Headers | show |
Hi, On Mon, Sep 17, 2012 at 3:56 PM, Kukjin Kim <kgene.kim@samsung.com> wrote: > Hi Arnd and Olof, > > Here is second Samsung fixes for v3.6. > > This includes using spin_lock_irqsave in clk_set_parent() to avoid spinlock > recursion and fixing wrong definitions. > > If any problems, please kindly let me know. > > Thanks. > > Best regards, > Kgene. > -- > Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, > SW Solution Development Team, Samsung Electronics Co., Ltd. > > The following changes since commit 4cbe5a555fa58a79b6ecbb6c531b8bab0650778d: > > Linux 3.6-rc4 (2012-09-01 10:39:58 -0700) > > are available in the git repository at: > git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git > v3.6-samsung-fixes-2 > > Julia Lawall (1): > ARM: S3C24xx: delete double assignment > > Mandeep Singh Baines (1): > ARM: SAMSUNG: use spin_lock_irqsave() in clk_set_parent > > Peter Senna Tschudin (1): > ARM: S3C24XX: removes unnecessary semicolon > > Seung-Woo Kim (1): > ARM: EXYNOS: fixed SYSMMU setup definition to mate parameter name We're very late in the release cycle for 3.6, and only critical fixes should go in -- no cleanups. Please queue those in a fixes-non-critical branch for 3.7 instead. Only the one from Mandeep seems to be a real bug fix, I think? -Olof
Olof Johansson wrote: > > Hi, > > > On Mon, Sep 17, 2012 at 3:56 PM, Kukjin Kim <kgene.kim@samsung.com> wrote: > > Hi Arnd and Olof, > > > > Here is second Samsung fixes for v3.6. > > > > This includes using spin_lock_irqsave in clk_set_parent() to avoid > spinlock > > recursion and fixing wrong definitions. > > > > If any problems, please kindly let me know. > > > > Thanks. > > > > Best regards, > > Kgene. > > -- > > Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, > > SW Solution Development Team, Samsung Electronics Co., Ltd. > > > > The following changes since commit > 4cbe5a555fa58a79b6ecbb6c531b8bab0650778d: > > > > Linux 3.6-rc4 (2012-09-01 10:39:58 -0700) > > > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git > > v3.6-samsung-fixes-2 > > > > Julia Lawall (1): > > ARM: S3C24xx: delete double assignment > > > > Mandeep Singh Baines (1): > > ARM: SAMSUNG: use spin_lock_irqsave() in clk_set_parent > > > > Peter Senna Tschudin (1): > > ARM: S3C24XX: removes unnecessary semicolon > > > > Seung-Woo Kim (1): > > ARM: EXYNOS: fixed SYSMMU setup definition to mate parameter name > > We're very late in the release cycle for 3.6, and only critical fixes > should go in -- no cleanups. Please queue those in a > fixes-non-critical branch for 3.7 instead. > > Only the one from Mandeep seems to be a real bug fix, I think? > Well...I don't think so, others also should be fixed before v3.6 because as you can see, it can occur unexpected behavior and must be wrong. But last one is small thing... Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
Hi, On Mon, Sep 17, 2012 at 4:05 PM, Kukjin Kim <kgene.kim@samsung.com> wrote: > Well...I don't think so, others also should be fixed before v3.6 because as > you can see, it can occur unexpected behavior and must be wrong. But last > one is small thing... "ARM: EXYNOS: fixed SYSMMU setup definition to mate parameter name" is a valid cleanup, but it has zero functional impact, it just reorders two unused arguments to a stub macro. "ARM: S3C24xx: delete double assignment" is a valid bugfix, but the bug was introduced in "ARM: S3C2410: H1940: Use leds-gpio driver for LEDs managing" in 2.6.39 so fixing it in 3.7 seems just as fine as 3.6, in my opinion -- it's gone unnoticed so far and was just found by tools. "ARM: S3C24XX: removes unnecessary semicolon" fixes a harmless extra semicolon after a switch statement. Valid cleanup but definitely not urgent for 3.6. -Olof
Olof Johansson wrote: > > Hi, > > On Mon, Sep 17, 2012 at 4:05 PM, Kukjin Kim <kgene.kim@samsung.com> wrote: > > > Well...I don't think so, others also should be fixed before v3.6 because > as > > you can see, it can occur unexpected behavior and must be wrong. But > last > > one is small thing... > > "ARM: EXYNOS: fixed SYSMMU setup definition to mate parameter name" is > a valid cleanup, but it has zero functional impact, it just reorders > two unused arguments to a stub macro. > > "ARM: S3C24xx: delete double assignment" is a valid bugfix, but the > bug was introduced in "ARM: S3C2410: H1940: Use leds-gpio driver for > LEDs managing" in 2.6.39 so fixing it in 3.7 seems just as fine as > 3.6, in my opinion -- it's gone unnoticed so far and was just found by > tools. > > "ARM: S3C24XX: removes unnecessary semicolon" fixes a harmless extra > semicolon after a switch statement. Valid cleanup but definitely not > urgent for 3.6. > Agreed. Let me sort out the branch for fixes soon, then re-send pull request. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
Hi Arnd and Olof, Here is second Samsung fixes for v3.6. This includes using spin_lock_irqsave in clk_set_parent() to avoid spinlock recursion and fixing wrong definitions. If any problems, please kindly let me know. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. The following changes since commit 4cbe5a555fa58a79b6ecbb6c531b8bab0650778d: Linux 3.6-rc4 (2012-09-01 10:39:58 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git v3.6-samsung-fixes-2 Julia Lawall (1): ARM: S3C24xx: delete double assignment Mandeep Singh Baines (1): ARM: SAMSUNG: use spin_lock_irqsave() in clk_set_parent Peter Senna Tschudin (1): ARM: S3C24XX: removes unnecessary semicolon Seung-Woo Kim (1): ARM: EXYNOS: fixed SYSMMU setup definition to mate parameter name arch/arm/mach-exynos/include/mach/sysmmu.h | 2 +- arch/arm/mach-s3c24xx/mach-h1940.c | 4 ++-- arch/arm/plat-samsung/clock.c | 5 +++-- 3 files changed, 6 insertions(+), 5 deletions(-)