Message ID | 87k3wl31j2.fsf@talisman.home |
---|---|
State | New |
Headers | show |
On Sun, 26 Aug 2012, Richard Sandiford wrote: > I'm preparing a patch to turn gcc.target/mips into a torture-like > testsuite. While on the subject of gcc.target/mips and its extensions, it also doesn't handle a build configured with --with-synci=yes. (Well, not on the 4.7 branch at least.) brgds, H-P
Hans-Peter Nilsson <hp@bitrange.com> writes: > On Sun, 26 Aug 2012, Richard Sandiford wrote: >> I'm preparing a patch to turn gcc.target/mips into a torture-like >> testsuite. > > While on the subject of gcc.target/mips and its extensions, it > also doesn't handle a build configured with --with-synci=yes. > (Well, not on the 4.7 branch at least.) What goes wrong? Richard
On Tue, 28 Aug 2012, Richard Sandiford wrote: > Hans-Peter Nilsson <hp@bitrange.com> writes: > > On Sun, 26 Aug 2012, Richard Sandiford wrote: > >> I'm preparing a patch to turn gcc.target/mips into a torture-like > >> testsuite. > > > > While on the subject of gcc.target/mips and its extensions, it > > also doesn't handle a build configured with --with-synci=yes. > > (Well, not on the 4.7 branch at least.) > > What goes wrong? I don't remember details, but IIRC some synci-related tests go wrong for mipsisa32r2el-linux-gnu due to -msynci being the default. Don't worry, I've fixed it in the local import. :) I though the above would entice you to try it, but I guess I need to report better for that to happen. Maybe later. brgds, H-P
Hans-Peter Nilsson <hp@bitrange.com> writes: > On Tue, 28 Aug 2012, Richard Sandiford wrote: >> Hans-Peter Nilsson <hp@bitrange.com> writes: >> > On Sun, 26 Aug 2012, Richard Sandiford wrote: >> >> I'm preparing a patch to turn gcc.target/mips into a torture-like >> >> testsuite. >> > >> > While on the subject of gcc.target/mips and its extensions, it >> > also doesn't handle a build configured with --with-synci=yes. >> > (Well, not on the 4.7 branch at least.) >> >> What goes wrong? > > I don't remember details, but IIRC some synci-related tests go > wrong for mipsisa32r2el-linux-gnu due to -msynci being the > default. Don't worry, I've fixed it in the local import. :) > I though the above would entice you to try it, but I guess I > need to report better for that to happen. Maybe later. Trying it now. I suspect it was the problem that Steve hit: the implicit -msynci is still (deliberately) kept when a lower architecture is selected. I'm testing a patch to make the testsuite work out the default -m{no,}synci, which ought to be enough. The usual rules should then kick in and force -mno-synci where necessary. Hopefully. Richard
Index: gcc/config/mips/mips.c =================================================================== --- gcc/config/mips/mips.c 2012-08-26 11:34:07.000000000 +0100 +++ gcc/config/mips/mips.c 2012-08-26 11:35:15.076810487 +0100 @@ -3841,7 +3841,7 @@ mips_rtx_costs (rtx x, int code, int out ? mips_cost->int_mult_si * 3 + 6 : COSTS_N_INSNS (ISA_HAS_MUL3 ? 7 : 9)); else if (!speed) - *total = (ISA_HAS_MUL3 ? 1 : 2); + *total = COSTS_N_INSNS (ISA_HAS_MUL3 ? 1 : 2); else if (mode == DImode) *total = mips_cost->int_mult_di; else