diff mbox

Patches to enable -ftrack-macro-expansion by default

Message ID alpine.LNX.2.00.1208260227370.5727@ghan.fvgr
State New
Headers show

Commit Message

Gerald Pfeifer Aug. 26, 2012, 12:28 a.m. UTC 
On Mon, 30 Apr 2012, Dodji Seketeli wrote:
> I have finally applied this series of 14 patches to the mainline today.
> The SVN revisions are from r186965 to r186978.

Shouldn't we document this in the release notes?

What do you guys think about the following?  Suggestions welcome.

Gerald

Comments

Gabriel Dos Reis Aug. 26, 2012, 12:40 a.m. UTC | #1 
On Sat, Aug 25, 2012 at 7:28 PM, Gerald Pfeifer <gerald@pfeifer.com> wrote:
> On Mon, 30 Apr 2012, Dodji Seketeli wrote:
>> I have finally applied this series of 14 patches to the mainline today.
>> The SVN revisions are from r186965 to r186978.
>
> Shouldn't we document this in the release notes?
>
> What do you guys think about the following?  Suggestions welcome.

Good idea.  See suggestion below.

>
> Gerald
>
> Index: changes.html
> ===================================================================
> RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-4.8/changes.html,v
> retrieving revision 1.17
> diff -u -3 -p -r1.17 changes.html
> --- changes.html        20 Aug 2012 12:23:39 -0000      1.17
> +++ changes.html        26 Aug 2012 00:27:32 -0000
> @@ -56,9 +56,14 @@ by this change.</p>
>  -->
>
>
> -<!--
>  <h3>C family</h3>
> --->
> +
> +  <ul>
> +    <li>The option <code>-ftrack-macro-expansion=2</code> is now
> +    enabled by default. This allows the compiler to emit diagnostic
> +    about the current macro expansion stack when a compilation error
> +    occurs.</li>
> +  </ul>

What about replacing the last sentence with:

              This allows the compiler to display macro expansion stack in
               diagnostics.

I think we show the stack not just for errors, but for any diagnostics.
Dodji Seketeli Aug. 26, 2012, 8:32 a.m. UTC | #2 
Gabriel Dos Reis <gdr@integrable-solutions.net> writes:

> I think we show the stack not just for errors, but for any diagnostics.

I agree, FWIW.
diff mbox

Patch

Index: changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-4.8/changes.html,v
retrieving revision 1.17
diff -u -3 -p -r1.17 changes.html
--- changes.html	20 Aug 2012 12:23:39 -0000	1.17
+++ changes.html	26 Aug 2012 00:27:32 -0000
@@ -56,9 +56,14 @@  by this change.</p>
 -->
 
 
-<!--
 <h3>C family</h3>
--->
+
+  <ul>
+    <li>The option <code>-ftrack-macro-expansion=2</code> is now
+    enabled by default. This allows the compiler to emit diagnostic
+    about the current macro expansion stack when a compilation error
+    occurs.</li>
+  </ul>
 
 <!--
 <h3>C</h3>