| Message ID | 50082E7F.7030800@siemens.com |
|---|---|
| State | New |
| Headers | show |
On Thu, 19 Jul 2012, Jan Kiszka wrote: > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > --- > configure | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > Applied, thanks.
On 07/19/2012 10:57 AM, Jan Kiszka wrote: > Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com> Broke the build. I'm also confused about why this is necessary. You can just set CONFIG_PCSPK=y in default-configs/${ARCH}.mak to enable it and indeed, it's enabled by default for a bunch of targets including x86_64. So... I'm confused what this is fixing. Since I suspect malc and Jan are asleep, I'm going to revert for now to fix the build. I'll happily help fix whatever Jan was trying to fix tomorrow. Regards, Anthony Liguori > --- > configure | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index 106209a..42adc8d 100755 > --- a/configure > +++ b/configure > @@ -90,8 +90,8 @@ static="no" > sparc_cpu="" > cross_prefix="" > audio_drv_list="" > -audio_card_list="ac97 es1370 sb16 hda" > -audio_possible_cards="ac97 es1370 sb16 cs4231a adlib gus hda" > +audio_card_list="ac97 es1370 sb16 hda pcspk" > +audio_possible_cards="ac97 es1370 sb16 cs4231a adlib gus hda pcspk" > block_drv_whitelist="" > host_cc="gcc" > helper_cflags=""
On Thu, 19 Jul 2012, Anthony Liguori wrote: > On 07/19/2012 10:57 AM, Jan Kiszka wrote: > > Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com> > > Broke the build. I'm also confused about why this is necessary. It built fine here[1]. So was i, but... > > You can just set CONFIG_PCSPK=y in default-configs/${ARCH}.mak to enable it > and indeed, it's enabled by default for a bunch of targets including x86_64. > > So... I'm confused what this is fixing. Since I suspect malc and Jan are > asleep, I'm going to revert for now to fix the build. [..snip..] [1] i386-softmmu, failing target is apparently ARM though.
On 2012-07-20 02:01, malc wrote: > On Thu, 19 Jul 2012, Anthony Liguori wrote: > >> On 07/19/2012 10:57 AM, Jan Kiszka wrote: >>> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com> >> >> Broke the build. I'm also confused about why this is necessary. > > It built fine here[1]. So was i, but... Yeah, sorry, was to quick to send a premature workaround instead of trying to understand what actually broke here. What happened is that pcspk is no longer selectable via -soundhw. And that is because CONFIG_PCSPK, used by arch_init.c to build the static soundhw arraw, is no longer selected at target built time. It became a host level define when we moved the speaker into hwlib. I will try to find some workaround at configure level. I guess, on the long run, we will have to refactor the audio backend to allow for runtime registration of drivers. Jan
diff --git a/configure b/configure index 106209a..42adc8d 100755 --- a/configure +++ b/configure @@ -90,8 +90,8 @@ static="no" sparc_cpu="" cross_prefix="" audio_drv_list="" -audio_card_list="ac97 es1370 sb16 hda" -audio_possible_cards="ac97 es1370 sb16 cs4231a adlib gus hda" +audio_card_list="ac97 es1370 sb16 hda pcspk" +audio_possible_cards="ac97 es1370 sb16 cs4231a adlib gus hda pcspk" block_drv_whitelist="" host_cc="gcc" helper_cflags=""
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> --- configure | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)