| Message ID | 1332254938-31023-2-git-send-email-walimisdev@gmail.com |
|---|---|
| State | New |
| Headers | show |
On Wed, Mar 21, 2012 at 12:43:49AM +0100, Stefan Weil wrote: >Am 20.03.2012 15:48, schrieb Liming Wang: >>Linux guest os often writes invalid cmd data to reset into read mode, >>which leads many qemu complaint. Here we place all the debug >>message into macro PFLASH_DEBUG. We can turn on the all debug info by >>define PFLASH_DEBUG if we want to debug pflash_cfi01. >> >>Signed-off-by: Liming Wang <walimisdev@gmail.com> >>--- >>hw/pflash_cfi01.c | 2 +- >>1 files changed, 1 insertions(+), 1 deletions(-) >> >>diff --git a/hw/pflash_cfi01.c b/hw/pflash_cfi01.c >>index 2e6fa71..4e39ea6 100644 >>--- a/hw/pflash_cfi01.c >>+++ b/hw/pflash_cfi01.c >>@@ -433,7 +433,7 @@ static void pflash_write(pflash_t *pfl, >>target_phys_addr_t offset, >>return; >> >>error_flash: >>- printf("%s: Unimplemented flash cmd sequence " >>+ DPRINTF("%s: Unimplemented flash cmd sequence " >>"(offset " TARGET_FMT_plx ", wcycle 0x%x cmd 0x%x value 0x%x)\n", >>__func__, offset, pfl->wcycle, pfl->cmd, value); > >Using the trace mechanism of QEMU might be better here than DPRINTF >It allows users to enable trace messages without recompilation. >See docs/tracing.txt for details. Agree, I'm also using that. > >I personally like this special printf statement, because it shows me If we want to reserve it, also don't expect anonying complaint by Linux, I suggest to skip special cmds that not used in pflash_cfi01, such as 0xaa, 0x55. How do you think so? >since several years that there _are_ flash command sequences which should >be implemented (just boot MIPS Malta with Linux). Maybe one day I'll fix Do you remeber what issues the command sequences, by bootloader or Linux? I fixed one Unimplemented flash cmd sequence in my first patch, it prints: "pflash_write: Unimplemented flash cmd sequence (offset 00000000, wcycle 0x0 cmd 0x0 value 0xf0)" >them. With DPRINTF, I'll never again get a reminder. If I can reproduce that, I may help to fix them. Thanks Liming Wang > >Regards, >Stefan Weil >
diff --git a/hw/pflash_cfi01.c b/hw/pflash_cfi01.c index 2e6fa71..4e39ea6 100644 --- a/hw/pflash_cfi01.c +++ b/hw/pflash_cfi01.c @@ -433,7 +433,7 @@ static void pflash_write(pflash_t *pfl, target_phys_addr_t offset, return; error_flash: - printf("%s: Unimplemented flash cmd sequence " + DPRINTF("%s: Unimplemented flash cmd sequence " "(offset " TARGET_FMT_plx ", wcycle 0x%x cmd 0x%x value 0x%x)\n", __func__, offset, pfl->wcycle, pfl->cmd, value);
Linux guest os often writes invalid cmd data to reset into read mode, which leads many qemu complaint. Here we place all the debug message into macro PFLASH_DEBUG. We can turn on the all debug info by define PFLASH_DEBUG if we want to debug pflash_cfi01. Signed-off-by: Liming Wang <walimisdev@gmail.com> --- hw/pflash_cfi01.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)