| Message ID | 1330630010-11241-7-git-send-email-alan@signal11.us |
|---|---|
| State | Superseded, archived |
| Headers | show |
Alan Ott wrote at Thursday, March 01, 2012 12:27 PM: > From: Arnd Bergmann <arnd@arndb.de> > > The USB_ULPI driver is selected by tegra, but can only be > built if at least one of USB or USB_GADGET is enabled. > The kernel fails to link if both are off. > diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig ... > @@ -10,6 +10,7 @@ config ARCH_TEGRA_2x_SOC ... > + select USB_GADGET if USB_SUPPORT && !USB I don't believe the Tegra USB driver supports gadget mode at present. Would the above be better written as: select USB if USB_SUPPORT And I wonder if the Tegra EHCI driver shouldn't be doing some of these selects, not the ARCH_TEGRA_* option. And this is probably required for Tegra30 too not just Tegra20.
On Thursday 01 March 2012, Stephen Warren wrote: > Alan Ott wrote at Thursday, March 01, 2012 12:27 PM: > > From: Arnd Bergmann <arnd@arndb.de> > > > > The USB_ULPI driver is selected by tegra, but can only be > > built if at least one of USB or USB_GADGET is enabled. > > The kernel fails to link if both are off. > > > diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig > ... > > @@ -10,6 +10,7 @@ config ARCH_TEGRA_2x_SOC > ... > > + select USB_GADGET if USB_SUPPORT && !USB > > I don't believe the Tegra USB driver supports gadget mode at present. ok. > Would the above be better written as: > > select USB if USB_SUPPORT That does not look correct either. There is no reason why USB can't be disabled with USB_SUPPORT enabled on other platforms. Maybe it's better to change the 'select USB_ULPI if USB_SUPPORT' into 'select USB_ULPI if USB' instead? Or maybe just don't select USB_ULPI to start with and put it into the defconfig instead. > And this is probably required for Tegra30 too not just Tegra20. Right. Tegra30 was not there when I did these patches, so it's probably missing in other places, too. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Arnd Bergmann wrote at Thursday, March 01, 2012 1:26 PM: > On Thursday 01 March 2012, Stephen Warren wrote: > > Alan Ott wrote at Thursday, March 01, 2012 12:27 PM: > > > From: Arnd Bergmann <arnd@arndb.de> > > > > > > The USB_ULPI driver is selected by tegra, but can only be > > > built if at least one of USB or USB_GADGET is enabled. > > > The kernel fails to link if both are off. > > > > > diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig > > ... > > > @@ -10,6 +10,7 @@ config ARCH_TEGRA_2x_SOC > > ... > > > + select USB_GADGET if USB_SUPPORT && !USB > > > > I don't believe the Tegra USB driver supports gadget mode at present. > > ok. > > > Would the above be better written as: > > > > select USB if USB_SUPPORT > > That does not look correct either. There is no reason why USB > can't be disabled with USB_SUPPORT enabled on other platforms. > > Maybe it's better to change the 'select USB_ULPI if USB_SUPPORT' > into 'select USB_ULPI if USB' instead? That sounds reasonable. > Or maybe just don't select > USB_ULPI to start with and put it into the defconfig instead. Perhaps USB_EHCI_TEGRA should depend on USB, and select USB_EHCI?
On Thursday 01 March 2012, Stephen Warren wrote: > > Or maybe just don't select > > USB_ULPI to start with and put it into the defconfig instead. > > Perhaps USB_EHCI_TEGRA should depend on USB, and select USB_EHCI? I think it should, but that is a different issue. All EHCI bus glues currently depend on USB_EHCI_HCD instead of selecting it. Changing that would likely break a number of other things that have come to depend on the current behavior. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig index b2a038e..7ac3011 100644 --- a/arch/arm/mach-tegra/Kconfig +++ b/arch/arm/mach-tegra/Kconfig @@ -10,6 +10,7 @@ config ARCH_TEGRA_2x_SOC select USB_ARCH_HAS_EHCI if USB_SUPPORT select USB_ULPI if USB_SUPPORT select USB_ULPI_VIEWPORT if USB_SUPPORT + select USB_GADGET if USB_SUPPORT && !USB select CPU_FREQ_TABLE if CPU_FREQ help Support for NVIDIA Tegra AP20 and T20 processors, based on the