| Message ID | 1329724647-15783-1-git-send-email-thierry.reding@avionic-design.de |
|---|---|
| State | Accepted, archived |
| Headers | show |
Thierry Reding wrote at Monday, February 20, 2012 12:57 AM: > To: linux-tegra@vger.kernel.org > Subject: [PATCH v2] ARM: tegra: PCIe: Provide 3.3V supply voltage > > The PCIe reference clock needs a 3.3V supply voltage to work properly. > > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de> Please CC maintainers on patches. It's a little odd that our downstream kernels have the same constraints as mainline and they're wrong, but as you say this could be explained by the bootloader fixing the issue, and/or nobody much using PCIe on Harmony. Anyway, I checked the schematics, and as far as I can tell from the schematic, this patch is indeed correct, so: Acked-by: Stephen Warren <swarren@nvidia.com>
On Mon, Feb 20, 2012 at 08:57:27AM +0100, Thierry Reding wrote: > The PCIe reference clock needs a 3.3V supply voltage to work properly. > > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de> > --- > This patch is based on next-20120217. Note that PCIe works without this > patch when the Linux kernel is booted with a combination of QuickBoot > and U-Boot because either apparently sets LD0 to 3.3V. This is not the > case when booting from mainline U-Boot, so it must be set explicitly. > > Changes in v2: > * Set voltage via constraints as suggested by Mark Brown. Thanks, applied to for-3.4/boards. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-tegra/board-harmony-power.c b/arch/arm/mach-tegra/board-harmony-power.c index 976edfb0..82f32300 100644 --- a/arch/arm/mach-tegra/board-harmony-power.c +++ b/arch/arm/mach-tegra/board-harmony-power.c @@ -31,13 +31,14 @@ static struct regulator_consumer_supply tps658621_ldo0_supply[] = { static struct regulator_init_data ldo0_data = { .constraints = { - .min_uV = 1250 * 1000, + .min_uV = 3300 * 1000, .max_uV = 3300 * 1000, .valid_modes_mask = (REGULATOR_MODE_NORMAL | REGULATOR_MODE_STANDBY), .valid_ops_mask = (REGULATOR_CHANGE_MODE | REGULATOR_CHANGE_STATUS | REGULATOR_CHANGE_VOLTAGE), + .apply_uV = 1, }, .num_consumer_supplies = ARRAY_SIZE(tps658621_ldo0_supply), .consumer_supplies = tps658621_ldo0_supply,
The PCIe reference clock needs a 3.3V supply voltage to work properly. Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de> --- This patch is based on next-20120217. Note that PCIe works without this patch when the Linux kernel is booted with a combination of QuickBoot and U-Boot because either apparently sets LD0 to 3.3V. This is not the case when booting from mainline U-Boot, so it must be set explicitly. Changes in v2: * Set voltage via constraints as suggested by Mark Brown. arch/arm/mach-tegra/board-harmony-power.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)