Message ID | CAAu8pHsMm0PUbFnhw5LWKJuu_fSa1a5px3Wykd0X4ennwtKYWA@mail.gmail.com |
---|---|
State | New |
Headers | show |
Am 18.02.2012 11:10, schrieb Blue Swirl: > There are still indentation problems when expressions continue to next > line, also this does not look OK: > --- a/target-sparc/translate.c > +++ b/target-sparc/translate.c > @@ -36,7 +36,7 @@ > > #define DYNAMIC_PC 1 /* dynamic pc value */ > #define JUMP_PC 2 /* dynamic pc value which takes only two values > - according to jump_pc[T2] */ > +according to jump_pc[T2] */ Writing comments like this looks nice, but needs more work when the comments are written. Maintenance of the code is also more difficult: any time a new line with a longer name is added, you have to reformat all other lines to preserve the good look. Just add this line to the code given above to see what I mean: #define ANY_LONG_PC 3 /* just an example */ This is why I usually write comments in an extra line before the code statement. Regards, Stefan
--- a/target-sparc/translate.c +++ b/target-sparc/translate.c @@ -36,7 +36,7 @@ #define DYNAMIC_PC 1 /* dynamic pc value */ #define JUMP_PC 2 /* dynamic pc value which takes only two values - according to jump_pc[T2] */ +according to jump_pc[T2] */ Moving the brace to same line as switch case should not be necessary.