diff mbox

[2/3] ARM: tegra: Enable the headphone detection gpio on PAZ00 board.

Message ID 1327517420-29746-1-git-send-email-leon@leon.nu
State Superseded, archived
Headers show

Commit Message

Leon Romanovsky Jan. 25, 2012, 6:50 p.m. UTC
Signed-off-by: Leon Romanovsky <leon@leon.nu>
---
 arch/arm/mach-tegra/board-paz00-pinmux.c |    1 +
 arch/arm/mach-tegra/board-paz00.h        |    3 +++
 2 files changed, 4 insertions(+), 0 deletions(-)

Comments

Stephen Warren Jan. 25, 2012, 10:23 p.m. UTC | #1
Leon Romanovsky wrote at Wednesday, January 25, 2012 11:50 AM:
> Signed-off-by: Leon Romanovsky <leon@leon.nu>

> diff --git a/arch/arm/mach-tegra/board-paz00-pinmux.c b/arch/arm/mach-tegra/board-paz00-pinmux.c
...
> @@ -152,6 +152,7 @@ static struct tegra_gpio_table gpio_table[] = {
...
> +	{ .gpio = TEGRA_HP_DET,		.enable = true },

There's no need to do this at all if you're only supporting audio when
booting use device tree. If you intend for audio to work when booting
using a board file, then the previous patch needs a bunch of rework
to make some of the code conditional on device tree; the same structure
as tegra_wm8903.c uses.

Talking of which, in the previous patch, you can remove a number of
things from tegra_alc5632.c if you are only supporting device tree, like
the DAPM route map, since that's parsed from device tree now.
Leon Romanovsky Jan. 26, 2012, 6:52 a.m. UTC | #2
On Thu, Jan 26, 2012 at 00:23, Stephen Warren <swarren@nvidia.com> wrote:
> Leon Romanovsky wrote at Wednesday, January 25, 2012 11:50 AM:
>> Signed-off-by: Leon Romanovsky <leon@leon.nu>
>
>> diff --git a/arch/arm/mach-tegra/board-paz00-pinmux.c b/arch/arm/mach-tegra/board-paz00-pinmux.c
> ...
>> @@ -152,6 +152,7 @@ static struct tegra_gpio_table gpio_table[] = {
> ...
>> +     { .gpio = TEGRA_HP_DET,         .enable = true },
>
> There's no need to do this at all if you're only supporting audio when
> booting use device tree. If you intend for audio to work when booting
> using a board file, then the previous patch needs a bunch of rework
> to make some of the code conditional on device tree; the same structure
> as tegra_wm8903.c uses.
>
> Talking of which, in the previous patch, you can remove a number of
> things from tegra_alc5632.c if you are only supporting device tree, like
> the DAPM route map, since that's parsed from device tree now.
Thanks for the input
As you mentioned we are going support only device tree.

>
> --
> nvpublic
>
diff mbox

Patch

diff --git a/arch/arm/mach-tegra/board-paz00-pinmux.c b/arch/arm/mach-tegra/board-paz00-pinmux.c
index c775572..4e261d3 100644
--- a/arch/arm/mach-tegra/board-paz00-pinmux.c
+++ b/arch/arm/mach-tegra/board-paz00-pinmux.c
@@ -152,6 +152,7 @@  static struct tegra_gpio_table gpio_table[] = {
 	{ .gpio = TEGRA_WIFI_PWRN,	.enable = true },
 	{ .gpio = TEGRA_WIFI_RST,	.enable = true },
 	{ .gpio = TEGRA_WIFI_LED,	.enable = true },
+	{ .gpio = TEGRA_HP_DET,		.enable = true },
 };
 
 static struct tegra_board_pinmux_conf conf = {
diff --git a/arch/arm/mach-tegra/board-paz00.h b/arch/arm/mach-tegra/board-paz00.h
index ffa83f5..77c8d83 100644
--- a/arch/arm/mach-tegra/board-paz00.h
+++ b/arch/arm/mach-tegra/board-paz00.h
@@ -32,6 +32,9 @@ 
 #define TEGRA_WIFI_RST			TEGRA_GPIO_PD1
 #define TEGRA_WIFI_LED			TEGRA_GPIO_PD0
 
+/* Audio */
+#define TEGRA_HP_DET           TEGRA_GPIO_PW2
+
 /* WakeUp */
 #define TEGRA_GPIO_POWERKEY	TEGRA_GPIO_PJ7