| Message ID | 1325220337-23165-1-git-send-email-b32955@freescale.com |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Dec 30, 2011 at 12:45:37PM +0800, Huang Shijie wrote: > The gpmi-nand driver needs the mxs-dma driver. So select the > MXS_DMA by default. So does the MTD_CHAR. > > Signed-off-by: Huang Shijie <b32955@freescale.com> > --- > drivers/mtd/nand/Kconfig | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > index 07c4774..1b14a3a 100644 > --- a/drivers/mtd/nand/Kconfig > +++ b/drivers/mtd/nand/Kconfig > @@ -420,6 +420,8 @@ config MTD_NAND_NANDSIM > config MTD_NAND_GPMI_NAND > bool "GPMI NAND Flash Controller driver" > depends on MTD_NAND && (SOC_IMX23 || SOC_IMX28) > + select MXS_DMA We should probably have it depend on MXS_DMA rather than select it. Regards, Shawn > + select MTD_CHAR > select MTD_PARTITIONS > select MTD_CMDLINE_PARTS > help > -- > 1.7.0.4
于 2011年12月31日 13:44, Shawn Guo 写道: > On Fri, Dec 30, 2011 at 12:45:37PM +0800, Huang Shijie wrote: >> The gpmi-nand driver needs the mxs-dma driver. So select the >> MXS_DMA by default. So does the MTD_CHAR. >> >> Signed-off-by: Huang Shijie<b32955@freescale.com> >> --- >> drivers/mtd/nand/Kconfig | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig >> index 07c4774..1b14a3a 100644 >> --- a/drivers/mtd/nand/Kconfig >> +++ b/drivers/mtd/nand/Kconfig >> @@ -420,6 +420,8 @@ config MTD_NAND_NANDSIM >> config MTD_NAND_GPMI_NAND >> bool "GPMI NAND Flash Controller driver" >> depends on MTD_NAND&& (SOC_IMX23 || SOC_IMX28) >> + select MXS_DMA > We should probably have it depend on MXS_DMA rather than select it. IMHO, I think `select` is better. :) The MXS_DMA not only service for NAND, but SD card, etc. In logic, the GPMI does not depends on MXS_DMA, the GPMI may use SDMA too(just in logically). Best Regards Huang Shijie > Regards, > Shawn > >> + select MTD_CHAR >> select MTD_PARTITIONS >> select MTD_CMDLINE_PARTS >> help >> -- >> 1.7.0.4
> 于 2011年12月31日 13:44, Shawn Guo 写道: > > On Fri, Dec 30, 2011 at 12:45:37PM +0800, Huang Shijie wrote: > >> The gpmi-nand driver needs the mxs-dma driver. So select the > >> MXS_DMA by default. So does the MTD_CHAR. > >> > >> Signed-off-by: Huang Shijie<b32955@freescale.com> > >> --- > >> > >> drivers/mtd/nand/Kconfig | 2 ++ > >> 1 files changed, 2 insertions(+), 0 deletions(-) > >> > >> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > >> index 07c4774..1b14a3a 100644 > >> --- a/drivers/mtd/nand/Kconfig > >> +++ b/drivers/mtd/nand/Kconfig > >> @@ -420,6 +420,8 @@ config MTD_NAND_NANDSIM > >> > >> config MTD_NAND_GPMI_NAND > >> > >> bool "GPMI NAND Flash Controller driver" > >> depends on MTD_NAND&& (SOC_IMX23 || SOC_IMX28) > >> > >> + select MXS_DMA > > > > We should probably have it depend on MXS_DMA rather than select it. > > IMHO, I think `select` is better. :) > The MXS_DMA not only service for NAND, but SD card, etc. > In logic, the GPMI does not depends on MXS_DMA, the GPMI may use SDMA > too(just in logically). And does it use that ? Technically, it's still dependent on MXS_DMA, right ? Also, why select mtd_char, it's totally unrelated. M > > > Best Regards > Huang Shijie > > > Regards, > > Shawn > > > >> + select MTD_CHAR > >> > >> select MTD_PARTITIONS > >> select MTD_CMDLINE_PARTS > >> > >> help > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
于 2011年12月31日 15:01, Marek Vasut 写道: >> 于 2011年12月31日 13:44, Shawn Guo 写道: >>> On Fri, Dec 30, 2011 at 12:45:37PM +0800, Huang Shijie wrote: >>>> The gpmi-nand driver needs the mxs-dma driver. So select the >>>> MXS_DMA by default. So does the MTD_CHAR. >>>> >>>> Signed-off-by: Huang Shijie<b32955@freescale.com> >>>> --- >>>> >>>> drivers/mtd/nand/Kconfig | 2 ++ >>>> 1 files changed, 2 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig >>>> index 07c4774..1b14a3a 100644 >>>> --- a/drivers/mtd/nand/Kconfig >>>> +++ b/drivers/mtd/nand/Kconfig >>>> @@ -420,6 +420,8 @@ config MTD_NAND_NANDSIM >>>> >>>> config MTD_NAND_GPMI_NAND >>>> >>>> bool "GPMI NAND Flash Controller driver" >>>> depends on MTD_NAND&& (SOC_IMX23 || SOC_IMX28) >>>> >>>> + select MXS_DMA >>> We should probably have it depend on MXS_DMA rather than select it. >> IMHO, I think `select` is better. :) >> The MXS_DMA not only service for NAND, but SD card, etc. >> In logic, the GPMI does not depends on MXS_DMA, the GPMI may use SDMA >> too(just in logically). > And does it use that ? Technically, it's still dependent on MXS_DMA, right ? NO. Just assumption. the GPMI driver will continue to depend on MXS_DMA in the following chips, such as MX6Q. > Also, why select mtd_char, it's totally unrelated. The GPMI works with UBIFS, the UBIFS is based on /dev/mtd0.., Huang Shijie > M >> >> Best Regards >> Huang Shijie >> >>> Regards, >>> Shawn >>> >>>> + select MTD_CHAR >>>> >>>> select MTD_PARTITIONS >>>> select MTD_CMDLINE_PARTS >>>> >>>> help >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Sat, Dec 31, 2011 at 01:48:00PM +0800, Huang Shijie wrote: > 于 2011年12月31日 13:44, Shawn Guo 写道: > >>+ select MXS_DMA > >We should probably have it depend on MXS_DMA rather than select it. > IMHO, I think `select` is better. :) > The MXS_DMA not only service for NAND, but SD card, etc. > In logic, the GPMI does not depends on MXS_DMA, the GPMI may use > SDMA too(just in logically). > Here is what Documentation/kbuild/kconfig-language.txt tells: select should be used with care. select will force a symbol to a value without visiting the dependencies. By abusing select you are able to select a symbol FOO even if FOO depends on BAR that is not set. In general use select only for non-visible symbols (no prompts anywhere) and for symbols with no dependencies. That will limit the usefulness but on the other hand avoid the illegal configurations all over.
Hi, thanks a lot! > Here is what Documentation/kbuild/kconfig-language.txt tells: > > select should be used with care. select will force > a symbol to a value without visiting the dependencies. :( I ever thought the select will do the dependencies automatically. I do not like the GPMI depend on the MXS-DMA. It looks very strange when you do the "make menuconfig". to Arterm: Maybe you can drop this patch. thanks Huang Shijie > By abusing select you are able to select a symbol FOO even > if FOO depends on BAR that is not set. > In general use select only for non-visible symbols > (no prompts anywhere) and for symbols with no dependencies. > That will limit the usefulness but on the other hand avoid > the illegal configurations all over. >
> I do not like the GPMI depend on the MXS-DMA. It looks very strange > when you do the "make menuconfig". That doesn't change that it DOES depend on it :) (You can't use GPMI without DMA, right?)
diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig index 07c4774..1b14a3a 100644 --- a/drivers/mtd/nand/Kconfig +++ b/drivers/mtd/nand/Kconfig @@ -420,6 +420,8 @@ config MTD_NAND_NANDSIM config MTD_NAND_GPMI_NAND bool "GPMI NAND Flash Controller driver" depends on MTD_NAND && (SOC_IMX23 || SOC_IMX28) + select MXS_DMA + select MTD_CHAR select MTD_PARTITIONS select MTD_CMDLINE_PARTS help
The gpmi-nand driver needs the mxs-dma driver. So select the MXS_DMA by default. So does the MTD_CHAR. Signed-off-by: Huang Shijie <b32955@freescale.com> --- drivers/mtd/nand/Kconfig | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)