Message ID | 20230307035030.437573-1-abushwangs@gmail.com |
---|---|
State | New |
Headers | show |
Series | nptl: pthread_rwlock_rdlock return in low priority | expand |
On Tue, 2023-03-07 at 11:50 +0800, abushwang via Libc-alpha wrote: > Signed-off-by: abushwang <abushwangs@gmail.com> > --- > nptl/pthread_rwlock_common.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/nptl/pthread_rwlock_common.c b/nptl/pthread_rwlock_common.c > index 5266a00ed1..35b00fc14f 100644 > --- a/nptl/pthread_rwlock_common.c > +++ b/nptl/pthread_rwlock_common.c > @@ -389,6 +389,7 @@ __pthread_rwlock_rdlock_full64 (pthread_rwlock_t *rwlock, clockid_t clockid, > complexity. */ > if (__glibc_likely ((r & PTHREAD_RWLOCK_WRPHASE) == 0)) > return 0; > + I don't think simply adding an empty line can fix anything. > /* Otherwise, if we were in a write phase (states #6 or #8), we must wait > for explicit hand-over of the read phase; the only exception is if we > can start a read phase if there is no primary writer currently. */ > -- > 2.36.1
ignore this empty line, i just want send this mail Xi Ruoyao <xry111@xry111.site> 于2023年3月7日周二 16:40写道: > On Tue, 2023-03-07 at 11:50 +0800, abushwang via Libc-alpha wrote: > > Signed-off-by: abushwang <abushwangs@gmail.com> > > --- > > nptl/pthread_rwlock_common.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/nptl/pthread_rwlock_common.c b/nptl/pthread_rwlock_common.c > > index 5266a00ed1..35b00fc14f 100644 > > --- a/nptl/pthread_rwlock_common.c > > +++ b/nptl/pthread_rwlock_common.c > > @@ -389,6 +389,7 @@ __pthread_rwlock_rdlock_full64 (pthread_rwlock_t > *rwlock, clockid_t clockid, > > complexity. */ > > if (__glibc_likely ((r & PTHREAD_RWLOCK_WRPHASE) == 0)) > > return 0; > > + > > I don't think simply adding an empty line can fix anything. > > > /* Otherwise, if we were in a write phase (states #6 or #8), we must > wait > > for explicit hand-over of the read phase; the only exception is if > we > > can start a read phase if there is no primary writer currently. */ > > -- > > 2.36.1 > > -- > Xi Ruoyao <xry111@xry111.site> > School of Aerospace Science and Technology, Xidian University >
* abushwang via Libc-alpha: > diff --git a/nptl/pthread_rwlock_common.c b/nptl/pthread_rwlock_common.c > index 5266a00ed1..35b00fc14f 100644 > --- a/nptl/pthread_rwlock_common.c > +++ b/nptl/pthread_rwlock_common.c > @@ -389,6 +389,7 @@ __pthread_rwlock_rdlock_full64 (pthread_rwlock_t *rwlock, clockid_t clockid, > complexity. */ > if (__glibc_likely ((r & PTHREAD_RWLOCK_WRPHASE) == 0)) > return 0; > + > /* Otherwise, if we were in a write phase (states #6 or #8), we must wait > for explicit hand-over of the read phase; the only exception is if we > can start a read phase if there is no primary writer currently. */ This does not seem to be the right patch? Thanks, Florian
Actually, i can not send mail without any change by git sendmail, so I add a empty line. This is just a mail for advisory Florian Weimer <fweimer@redhat.com> 于2023年3月7日周二 16:56写道: > * abushwang via Libc-alpha: > > > diff --git a/nptl/pthread_rwlock_common.c b/nptl/pthread_rwlock_common.c > > index 5266a00ed1..35b00fc14f 100644 > > --- a/nptl/pthread_rwlock_common.c > > +++ b/nptl/pthread_rwlock_common.c > > @@ -389,6 +389,7 @@ __pthread_rwlock_rdlock_full64 (pthread_rwlock_t > *rwlock, clockid_t clockid, > > complexity. */ > > if (__glibc_likely ((r & PTHREAD_RWLOCK_WRPHASE) == 0)) > > return 0; > > + > > /* Otherwise, if we were in a write phase (states #6 or #8), we must > wait > > for explicit hand-over of the read phase; the only exception is if > we > > can start a read phase if there is no primary writer currently. */ > > This does not seem to be the right patch? > > Thanks, > Florian > >
On Tue, 2023-03-07 at 17:06 +0800, abush wang via Libc-alpha wrote: > Actually, i can not send mail without any change by git sendmail, so I > add > a empty line. > This is just a mail for advisory Don't use git send-email then. It's a utility to send patches as mails, not ordinary mails. If you need a CLI tool for email use sendmail or something. > > Florian Weimer <fweimer@redhat.com> 于2023年3月7日周二 16:56写道: > > > * abushwang via Libc-alpha: > > > > > diff --git a/nptl/pthread_rwlock_common.c > > > b/nptl/pthread_rwlock_common.c > > > index 5266a00ed1..35b00fc14f 100644 > > > --- a/nptl/pthread_rwlock_common.c > > > +++ b/nptl/pthread_rwlock_common.c > > > @@ -389,6 +389,7 @@ __pthread_rwlock_rdlock_full64 > > > (pthread_rwlock_t > > *rwlock, clockid_t clockid, > > > complexity. */ > > > if (__glibc_likely ((r & PTHREAD_RWLOCK_WRPHASE) == 0)) > > > return 0; > > > + > > > /* Otherwise, if we were in a write phase (states #6 or #8), we > > > must > > wait > > > for explicit hand-over of the read phase; the only exception > > > is if > > we > > > can start a read phase if there is no primary writer > > > currently. */ > > > > This does not seem to be the right patch? > > > > Thanks, > > Florian > > > >
diff --git a/nptl/pthread_rwlock_common.c b/nptl/pthread_rwlock_common.c index 5266a00ed1..35b00fc14f 100644 --- a/nptl/pthread_rwlock_common.c +++ b/nptl/pthread_rwlock_common.c @@ -389,6 +389,7 @@ __pthread_rwlock_rdlock_full64 (pthread_rwlock_t *rwlock, clockid_t clockid, complexity. */ if (__glibc_likely ((r & PTHREAD_RWLOCK_WRPHASE) == 0)) return 0; + /* Otherwise, if we were in a write phase (states #6 or #8), we must wait for explicit hand-over of the read phase; the only exception is if we can start a read phase if there is no primary writer currently. */