| Message ID | 1323459914-25294-1-git-send-email-computersforpeace@gmail.com |
|---|---|
| State | Accepted |
| Commit | ec985197e7cd6ec33f41273bff7afd4c4f454b87 |
| Headers | show |
On Fri, 2011-12-09 at 11:45 -0800, Brian Norris wrote: > MEMWRITE is a recently introduced write interface for MTD; however, it > is, for now, only supported on NAND flash. mtd-utils should fall back to > old write methods when either ENOTTY or EOPNOTSUPP are returned. I've removed "for now, " because I am not sure it will ever be, and pushed this to mtd-utils.git, thanks! Artem.
diff --git a/lib/libmtd.c b/lib/libmtd.c index 1b16de5..9b247ae 100644 --- a/lib/libmtd.c +++ b/lib/libmtd.c @@ -1151,7 +1151,7 @@ int mtd_write(libmtd_t desc, const struct mtd_dev_info *mtd, int fd, int eb, ret = ioctl(fd, MEMWRITE, &ops); if (ret == 0) return 0; - else if (errno != ENOTTY) + else if (errno != ENOTTY && errno != EOPNOTSUPP) return mtd_ioctl_error(mtd, eb, "MEMWRITE"); /* Fall back to old methods if necessary */
MEMWRITE is a recently introduced write interface for MTD; however, it is, for now, only supported on NAND flash. mtd-utils should fall back to old write methods when either ENOTTY or EOPNOTSUPP are returned. This is a showstopper when, for instance, using ubiformat on NOR, which don't have a mtd->write_oob interface (and thus don't support MEMWRITE): ubiformat: formatting eraseblock 2 -- 1 % complete libmtd: error!: MEMWRITE ioctl failed for eraseblock 2 (mtd3) error 122 (Operation not supported) Signed-off-by: Brian Norris <computersforpeace@gmail.com> --- lib/libmtd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)