diff mbox series

[ovs-dev,1/6] ci: Fix overriding OPTS provided from the yml.

Message ID 20221210021620.2699347-2-i.maximets@ovn.org
State Superseded
Headers show
Series AF_XDP build fixes and enhancements. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/intel-ovs-compilation success test: success

Commit Message

Ilya Maximets Dec. 10, 2022, 2:16 a.m. UTC
For GCC builds we're overriding --disbale-ssl or --enable-shared
options set up in the GHA yml file.

Fix that by adding to EXTRA_OPTS instead.

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
---
 .ci/linux-build.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Marchand Dec. 12, 2022, 4:16 p.m. UTC | #1
On Sat, Dec 10, 2022 at 3:16 AM Ilya Maximets <i.maximets@ovn.org> wrote:
>
> For GCC builds we're overriding --disbale-ssl or --enable-shared

Nit: disable*

> options set up in the GHA yml file.
>
> Fix that by adding to EXTRA_OPTS instead.

Hum, I think it:
Fixes: 2581b0ad1159 ("travis: Combine kernel builds.")


>
> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>

Otherwise, lgtm.
diff mbox series

Patch

diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index 485109672..1f8896423 100755
--- a/.ci/linux-build.sh
+++ b/.ci/linux-build.sh
@@ -246,7 +246,7 @@  elif [ "$M32" ]; then
     # difference on 'configure' and 'make' stages.
     export CC="$CC -m32"
 elif [ "$TRAVIS_ARCH" != "aarch64" ]; then
-    OPTS="--enable-sparse"
+    EXTRA_OPTS="$EXTRA_OPTS --enable-sparse"
     if [ "$AFXDP" ]; then
         # netdev-afxdp uses memset for 64M for umem initialization.
         SPARSE_FLAGS="${SPARSE_FLAGS} -Wno-memcpy-max-count"