| Message ID | 20220911111200.199182-2-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | pinctrl/arm64: qcom: fix some of Qualcomm pinctrl schema warnings | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 9/11/22 14:11, Krzysztof Kozlowski wrote: > Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern > does not work as expected because of linux,phandle in the DTB: > > 'pins' is a required property > 'function' is a required property > 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' > [[59]] is not of type 'object' > > Make the schema stricter and expect such nodes to be either named > 'pinconfig' or followed with '-pins' prefix. Well, now you don't allow pinconfig, so maybe tweak the commit message. > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Iskren Chernev <iskren.chernev@gmail.com>
On 11/09/2022 14:59, Iskren Chernev wrote: > > > > On 9/11/22 14:11, Krzysztof Kozlowski wrote: >> Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern >> does not work as expected because of linux,phandle in the DTB: >> >> 'pins' is a required property >> 'function' is a required property >> 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' >> [[59]] is not of type 'object' >> >> Make the schema stricter and expect such nodes to be either named >> 'pinconfig' or followed with '-pins' prefix. > > Well, now you don't allow pinconfig, so maybe tweak the commit message. True, thanks! Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml index d8443811767d..8a2b4767c7b6 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml @@ -59,8 +59,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sm6115-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sm6115-tlmm-state" + additionalProperties: false '$defs': qcom-sm6115-tlmm-state: @@ -155,25 +156,25 @@ examples: gpio-ranges = <&tlmm 0 0 114>; sdc2_on_state: sdc2-on-state { - clk { + clk-pins { pins = "sdc2_clk"; bias-disable; drive-strength = <16>; }; - cmd { + cmd-pins { pins = "sdc2_cmd"; bias-pull-up; drive-strength = <10>; }; - data { + data-pins { pins = "sdc2_data"; bias-pull-up; drive-strength = <10>; }; - sd-cd { + sd-cd-pins { pins = "gpio88"; function = "gpio"; bias-pull-up;
Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be either named 'pinconfig' or followed with '-pins' prefix. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)