Message ID | 1319193121-2729-4-git-send-email-jeffrey.t.kirsher@intel.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
On Fri, Oct 21, 2011 at 03:31:59AM -0700, Jeff Kirsher wrote: > From: Carolyn Wyborny <carolyn.wyborny@intel.com> > > In 82580 and later devices, the alternate MAC address feature is > completely handled by the option ROM and software does not handle > it anymore. This patch changes the check_alt_mac_addr function to > exit immediately if device is 82580 or later. 'Stupid' question: what happens if you put such a card with an x86 Option ROM into a, say, PowerPC server? Just feeling like the devil's advocate today :) -David -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/intel/igb/e1000_mac.c b/drivers/net/ethernet/intel/igb/e1000_mac.c index 872119d..bad3e14 100644 --- a/drivers/net/ethernet/intel/igb/e1000_mac.c +++ b/drivers/net/ethernet/intel/igb/e1000_mac.c @@ -191,6 +191,13 @@ s32 igb_check_alt_mac_addr(struct e1000_hw *hw) u16 offset, nvm_alt_mac_addr_offset, nvm_data; u8 alt_mac_addr[ETH_ALEN]; + /* + * Alternate MAC address is handled by the option ROM for 82580 + * and newer. SW support not required. + */ + if (hw->mac.type >= e1000_82580) + goto out; + ret_val = hw->nvm.ops.read(hw, NVM_ALT_MAC_ADDR_PTR, 1, &nvm_alt_mac_addr_offset); if (ret_val) {