Message ID | 1316844884-21700-1-git-send-email-santosh.shilimkar@ti.com |
---|---|
State | New |
Headers | show |
Hi Santosh, Santosh Shilimkar <santosh.shilimkar@ti.com> writes: > The series adds OMAP4 MPUSS (MPU SubSystem) power management support for > suspend (S2R), CPU hotplug and CPUidle. No need to repost, but can you update the versions in your branch to have an ARM: prefix in the subject per Arnd's recent request? Thanks, Kevin
On Tuesday 04 October 2011 10:35 PM, Kevin Hilman wrote: > Hi Santosh, > > Santosh Shilimkar <santosh.shilimkar@ti.com> writes: > >> The series adds OMAP4 MPUSS (MPU SubSystem) power management support for >> suspend (S2R), CPU hotplug and CPUidle. > > No need to repost, but can you update the versions in your branch to > have an ARM: prefix in the subject per Arnd's recent request? > Done. Branch for_3_2/omap4-mpuss-pm is updated with ARM on all patches. Regards Santosh
Hi Santosh, Santosh Shilimkar <santosh.shilimkar@ti.com> writes: > The series adds OMAP4 MPUSS (MPU SubSystem) power management support for > suspend (S2R), CPU hotplug and CPUidle. Just noticed when doing some final build/sanity testing that there are a few of compile/link warnings/problems when the kernel is built without CONFIG_PM Some warnings: /work/kernel/omap/pm/arch/arm/mach-omap2/omap-wakeupgen.c:203:13: warning: 'irq_save_context' defined but not used /work/kernel/omap/pm/arch/arm/mach-omap2/omap-wakeupgen.c:270:13: warning: 'irq_save_secure_context' defined but not used and some failures (these happen when CONFIG_SUSPEND=n but CONFIG_PM_RUNTIME=y: arch/arm/mach-omap2/built-in.o: In function `skip_l2en': /work/kernel/omap/pm/arch/arm/mach-omap2/sleep44xx.S:323: undefined reference to `cpu_resume' arch/arm/mach-omap2/built-in.o: In function `omap_sram_idle': /work/kernel/omap/pm/arch/arm/mach-omap2/pm34xx.c:429: undefined reference to `cpu_suspend' arch/arm/mach-omap2/built-in.o: In function `skipl2reen': /work/kernel/omap/pm/arch/arm/mach-omap2/sleep34xx.S:534: undefined reference to `cpu_resume' arch/arm/mach-omap2/built-in.o: In function `omap4_enter_lowpower': /work/kernel/omap/pm/arch/arm/mach-omap2/omap-mpuss-lowpower.c:281: undefined reference to `cpu_suspend' Turns out these are not directly related to your series and OMAP3 exhibits the same problems. I just posted a patch[1] to attempt to address these. But could you fixup the first problem and test with [1] to see if things still build/work as expected. Thanks, Kevin [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2011-October/068606.html
Kevin Hilman <khilman@ti.com> writes: > Hi Santosh, > > Santosh Shilimkar <santosh.shilimkar@ti.com> writes: > >> The series adds OMAP4 MPUSS (MPU SubSystem) power management support for >> suspend (S2R), CPU hotplug and CPUidle. > > Just noticed when doing some final build/sanity testing that there are a > few of compile/link warnings/problems when the kernel is built without > CONFIG_PM > > Some warnings: > > /work/kernel/omap/pm/arch/arm/mach-omap2/omap-wakeupgen.c:203:13: warning: 'irq_save_context' defined but not used > /work/kernel/omap/pm/arch/arm/mach-omap2/omap-wakeupgen.c:270:13: warning: 'irq_save_secure_context' defined but not used > > and some failures (these happen when CONFIG_SUSPEND=n but CONFIG_PM_RUNTIME=y: > > arch/arm/mach-omap2/built-in.o: In function `skip_l2en': > /work/kernel/omap/pm/arch/arm/mach-omap2/sleep44xx.S:323: undefined reference to `cpu_resume' > arch/arm/mach-omap2/built-in.o: In function `omap_sram_idle': > /work/kernel/omap/pm/arch/arm/mach-omap2/pm34xx.c:429: undefined reference to `cpu_suspend' > arch/arm/mach-omap2/built-in.o: In function `skipl2reen': > /work/kernel/omap/pm/arch/arm/mach-omap2/sleep34xx.S:534: undefined reference to `cpu_resume' > arch/arm/mach-omap2/built-in.o: In function `omap4_enter_lowpower': > /work/kernel/omap/pm/arch/arm/mach-omap2/omap-mpuss-lowpower.c:281: undefined reference to `cpu_suspend' > > Turns out these are not directly related to your series and OMAP3 > exhibits the same problems. > > I just posted a patch[1] to attempt to address these. > > But could you fixup the first problem and test with [1] to see if things > still build/work as expected. OK, ignore my patch. Arnd already has a fix for these link problems in his randconfig/arm branch. Please just cleanup the wakeupgen compile warnings and update your branch. Kevin
On Saturday 08 October 2011 04:20 AM, Kevin Hilman wrote: > Kevin Hilman <khilman@ti.com> writes: > >> Hi Santosh, >> >> Santosh Shilimkar <santosh.shilimkar@ti.com> writes: >> >>> The series adds OMAP4 MPUSS (MPU SubSystem) power management support for >>> suspend (S2R), CPU hotplug and CPUidle. >> >> Just noticed when doing some final build/sanity testing that there are a >> few of compile/link warnings/problems when the kernel is built without >> CONFIG_PM >> >> Some warnings: >> >> /work/kernel/omap/pm/arch/arm/mach-omap2/omap-wakeupgen.c:203:13: warning: 'irq_save_context' defined but not used >> /work/kernel/omap/pm/arch/arm/mach-omap2/omap-wakeupgen.c:270:13: warning: 'irq_save_secure_context' defined but not used >> Sory I missed it in my builds. [...] > Please just cleanup the wakeupgen compile warnings and update your > branch. > Done !! Updated branch : for_3_2/omap4-mpuss-pm_2 Regards Santosh
Hi Santosh, Santosh Shilimkar <santosh.shilimkar@ti.com> writes: > The series adds OMAP4 MPUSS (MPU SubSystem) power management support for > suspend (S2R), CPU hotplug and CPUidle. There are a few more compile errors when doing OMAP1-only builds. You'll need a way to eliminate the secure calls for OMAP1. This series causes a couple build errors when doing OMAP1-only builds (I used omap1_defconfig): First: /work/kernel/omap/pm/arch/arm/plat-omap/common.c:24:30: fatal error: mach/omap-secure.h: No such file or directory And trying creating a dummy header to see if it would continue to build gives: /work/kernel/omap/pm/arch/arm/plat-omap/common.c: In function 'omap_reserve': /work/kernel/omap/pm/arch/arm/plat-omap/common.c:70:2: error: implicit declaration of function 'omap_secure_ram_reserve_memblock' make[2]: *** [arch/arm/plat-omap/common.o] Error 1 make[1]: *** [arch/arm/plat-omap] Error 2 Kevin
Santosh Shilimkar <santosh.shilimkar@ti.com> writes: > On Monday 10 October 2011 11:31 PM, Kevin Hilman wrote: >> Hi Santosh, >> >> Santosh Shilimkar <santosh.shilimkar@ti.com> writes: >> >>> The series adds OMAP4 MPUSS (MPU SubSystem) power management support for >>> suspend (S2R), CPU hotplug and CPUidle. >> >> There are a few more compile errors when doing OMAP1-only builds. >> You'll need a way to eliminate the secure calls for OMAP1. >> >> This series causes a couple build errors when doing OMAP1-only builds >> (I used omap1_defconfig): >> > OK. Thanks for catching it. > >> First: >> >> /work/kernel/omap/pm/arch/arm/plat-omap/common.c:24:30: fatal error: mach/omap-secure.h: No such file or directory >> >> And trying creating a dummy header to see if it would continue to build gives: >> >> /work/kernel/omap/pm/arch/arm/plat-omap/common.c: In function 'omap_reserve': >> /work/kernel/omap/pm/arch/arm/plat-omap/common.c:70:2: error: implicit declaration of function 'omap_secure_ram_reserve_memblock' >> make[2]: *** [arch/arm/plat-omap/common.o] Error 1 >> make[1]: *** [arch/arm/plat-omap] Error 2 >> > For OMAP1 build, omap_secure_ram_reserve_memblock() definition is > needed since common.c is built for OMAP1 as well. > The trivial change in the end of this email fixes the omap1 build. Looks good. > Have folded that change in original patch and updated the OMAP4 > PM branch - for_3_2/omap4-mpuss-pm_2 Thanks. > Regards > Santosh > P.S : Even with this fix, omap1_defconfig build breaks because of USB. > I removed USB from build to check rest of the build and it was > fine then. OK. Kevin