diff mbox

Re: PATCH: /proc/acpi/alarm: handle day-of-month wraparound on readback

Message ID 49346212.3050102@rtr.ca
State Not Applicable, archived
Headers show

Commit Message

Mark Lord Dec. 1, 2008, 10:15 p.m. UTC 
Len Brown wrote:
> I don't have a /proc/acpi/alarm due to this:
> 
> #if defined(CONFIG_RTC_DRV_CMOS) || defined(CONFIG_RTC_DRV_CMOS_MODULE) || 
> !defined(CONFIG_X86)
> /* use /sys/class/rtc/rtcX/wakealarm instead; it's not ACPI-specific */
> #else
> #define HAVE_ACPI_LEGACY_ALARM
> #endif
..

Yeah.. bit of a nuisance that.
I regularly apply this patch to my own kernels:


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
-~----------~----~----~----~------~----~------~--~---

Comments

Alessandro Zummo Dec. 1, 2008, 10:32 p.m. UTC | #1 
On Mon, 01 Dec 2008 17:15:46 -0500
Mark Lord <lkml@rtr.ca> wrote:

> Yeah.. bit of a nuisance that.
> I regularly apply this patch to my own kernels:

 While it will certainly work, maybe it's time to switch
 to /sys/class/rtc/rtcX/wakealarm .
Mark Lord Dec. 2, 2008, 6:57 p.m. UTC | #2 
Alessandro Zummo wrote:
> On Mon, 01 Dec 2008 17:15:46 -0500
> Mark Lord <lkml@rtr.ca> wrote:
> 
>> Yeah.. bit of a nuisance that.
>> I regularly apply this patch to my own kernels:
> 
>  While it will certainly work, maybe it's time to switch
>  to /sys/class/rtc/rtcX/wakealarm . 
..

Perhaps, but doing so would still leave the but in /proc/acpi/alarm,
so we need to fix it regardless.

Cheers

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
-~----------~----~----~----~------~----~------~--~---
diff mbox

Patch

--- old/drivers/acpi/sleep/proc.c	2008-01-06 16:39:45.000000000 -0500
+++ linux/drivers/acpi/sleep/proc.c	2008-01-06 17:35:35.000000000 -0500
@@ -78,11 +78,11 @@ 
 }
 #endif				/* CONFIG_ACPI_PROCFS */
 
-#if defined(CONFIG_RTC_DRV_CMOS) || defined(CONFIG_RTC_DRV_CMOS_MODULE) || !defined(CONFIG_X86)
+//#if defined(CONFIG_RTC_DRV_CMOS) || defined(CONFIG_RTC_DRV_CMOS_MODULE) || !defined(CONFIG_X86)
 /* use /sys/class/rtc/rtcX/wakealarm instead; it's not ACPI-specific */
-#else
+//#else
 #define	HAVE_ACPI_LEGACY_ALARM
-#endif
+//#endif
 
 #ifdef	HAVE_ACPI_LEGACY_ALARM