Message ID | 20210421192233.3542904-1-jsnow@redhat.com |
---|---|
Headers | show |
Series | qapi: static typing conversion, pt4 | expand |
John Snow <jsnow@redhat.com> writes: > Hi, this series adds static type hints to the QAPI module. > This is part four, and focuses on error.py. > > Part 4: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt4 > CI: https://gitlab.com/jsnow/qemu/-/pipelines/290152364 > > Requirements: > - Python 3.6+ > - mypy >= 0.770 > - pylint >= 2.6.0 (2.7.0+ when using Python 3.9+) > > Every commit should pass with: > - `isort -c qapi/` > - `flake8 qapi/` > - `pylint --rcfile=qapi/pylintrc qapi/` > - `mypy --config-file=qapi/mypy.ini qapi/` I doubt PATCH 1 is worth the trouble without an actual concrete location-less error. However, arguing about it some more would also not worth the trouble, so: Reviewed-by: Markus Armbruster <armbru@redhat.com> and queued. Thanks!
On 4/22/21 4:09 AM, Markus Armbruster wrote: > John Snow <jsnow@redhat.com> writes: > >> Hi, this series adds static type hints to the QAPI module. >> This is part four, and focuses on error.py. >> >> Part 4: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt4 >> CI: https://gitlab.com/jsnow/qemu/-/pipelines/290152364 >> >> Requirements: >> - Python 3.6+ >> - mypy >= 0.770 >> - pylint >= 2.6.0 (2.7.0+ when using Python 3.9+) >> >> Every commit should pass with: >> - `isort -c qapi/` >> - `flake8 qapi/` >> - `pylint --rcfile=qapi/pylintrc qapi/` >> - `mypy --config-file=qapi/mypy.ini qapi/` > > I doubt PATCH 1 is worth the trouble without an actual concrete > location-less error. However, arguing about it some more would also not > worth the trouble, so: > > Reviewed-by: Markus Armbruster <armbru@redhat.com> > > and queued. Thanks! > FWIW, I use it a few times in Part 5a: - Once in main.py, to wrap an OSError (You'll see why) - Again in qapidoc to create a "QAPIDocError" class, but this is only used in PoC code to demonstrate that QAPISchemaParser is fully typed. I am finding it handy, though it may be true we wind up not needing it, based on reviews in part 5. Thanks for queueing it up! --js (Why does tbird spellcheck not think 'queueing' is a word?)