diff mbox series

[v1,1/1] igc: Fix prototype warning

Message ID 20210307084427.2882842-1-sasha.neftin@intel.com
State Accepted
Delegated to: Anthony Nguyen
Headers show
Series [v1,1/1] igc: Fix prototype warning | expand

Commit Message

Sasha Neftin March 7, 2021, 8:44 a.m. UTC
Correct report warnings in igc_i225.c

Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
---
 drivers/net/ethernet/intel/igc/igc_i225.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul Menzel March 9, 2021, 8:17 a.m. UTC | #1
Dear Sasha,


Thank you for the patch.


Am 07.03.21 um 09:44 schrieb Sasha Neftin:
> Correct report warnings in igc_i225.c

It’d be great, if you added somewhere it’s about the comment/function 
documentation (DoxyGen). Maybe as summary:

> igc: Fix function name in `igc_acquire_nvm_i225()` Doxygen comment

> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_i225.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc_i225.c b/drivers/net/ethernet/intel/igc/igc_i225.c
> index 7ec04e48860c..cc83bb5c15e8 100644
> --- a/drivers/net/ethernet/intel/igc/igc_i225.c
> +++ b/drivers/net/ethernet/intel/igc/igc_i225.c
> @@ -6,7 +6,7 @@
>   #include "igc_hw.h"
>   
>   /**
> - * igc_get_hw_semaphore_i225 - Acquire hardware semaphore
> + * igc_acquire_nvm_i225 - Acquire exclusive access to EEPROM
>    * @hw: pointer to the HW structure
>    *
>    * Acquire the necessary semaphores for exclusive access to the EEPROM.

Acked-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul
diff mbox series

Patch

diff --git a/drivers/net/ethernet/intel/igc/igc_i225.c b/drivers/net/ethernet/intel/igc/igc_i225.c
index 7ec04e48860c..cc83bb5c15e8 100644
--- a/drivers/net/ethernet/intel/igc/igc_i225.c
+++ b/drivers/net/ethernet/intel/igc/igc_i225.c
@@ -6,7 +6,7 @@ 
 #include "igc_hw.h"
 
 /**
- * igc_get_hw_semaphore_i225 - Acquire hardware semaphore
+ * igc_acquire_nvm_i225 - Acquire exclusive access to EEPROM
  * @hw: pointer to the HW structure
  *
  * Acquire the necessary semaphores for exclusive access to the EEPROM.