mbox series

[v2,for-6.0,0/8] nbd reconnect on open

Message ID 20201130134024.19212-1-vsementsov@virtuozzo.com
Headers show
Series nbd reconnect on open | expand

Message

Vladimir Sementsov-Ogievskiy Nov. 30, 2020, 1:40 p.m. UTC
Hi all! There is a new feature: reconnect on open. It is useful when
start of vm and start of nbd server are not simple to sync.

v2: rebase on master.
Also, I've discovered that I've sent downstream version of test which
doesn't work here. So, the test is rewritten (with appropriate
improvements of iotests.py)

Vladimir Sementsov-Ogievskiy (8):
  block/nbd: move initial connect to coroutine
  nbd: allow reconnect on open, with corresponding new options
  iotests.py: fix qemu_tool_pipe_and_status()
  iotests.py: qemu_io(): reuse qemu_tool_pipe_and_status()
  iotests.py: add qemu_tool_popen()
  iotests.py: add and use qemu_io_wrap_args()
  iotests.py: add qemu_io_popen()
  iotests: add 306 to test reconnect on nbd open

 block/nbd.c                   | 173 +++++++++++++++++++++++++---------
 tests/qemu-iotests/306        |  71 ++++++++++++++
 tests/qemu-iotests/306.out    |  11 +++
 tests/qemu-iotests/group      |   1 +
 tests/qemu-iotests/iotests.py |  56 +++++++----
 5 files changed, 246 insertions(+), 66 deletions(-)
 create mode 100755 tests/qemu-iotests/306
 create mode 100644 tests/qemu-iotests/306.out

Comments

Vladimir Sementsov-Ogievskiy Dec. 18, 2020, 10:57 a.m. UTC | #1
ping :)

30.11.2020 16:40, Vladimir Sementsov-Ogievskiy wrote:
> Hi all! There is a new feature: reconnect on open. It is useful when
> start of vm and start of nbd server are not simple to sync.
> 
> v2: rebase on master.
> Also, I've discovered that I've sent downstream version of test which
> doesn't work here. So, the test is rewritten (with appropriate
> improvements of iotests.py)
> 
> Vladimir Sementsov-Ogievskiy (8):
>    block/nbd: move initial connect to coroutine
>    nbd: allow reconnect on open, with corresponding new options
>    iotests.py: fix qemu_tool_pipe_and_status()
>    iotests.py: qemu_io(): reuse qemu_tool_pipe_and_status()
>    iotests.py: add qemu_tool_popen()
>    iotests.py: add and use qemu_io_wrap_args()
>    iotests.py: add qemu_io_popen()
>    iotests: add 306 to test reconnect on nbd open
> 
>   block/nbd.c                   | 173 +++++++++++++++++++++++++---------
>   tests/qemu-iotests/306        |  71 ++++++++++++++
>   tests/qemu-iotests/306.out    |  11 +++
>   tests/qemu-iotests/group      |   1 +
>   tests/qemu-iotests/iotests.py |  56 +++++++----
>   5 files changed, 246 insertions(+), 66 deletions(-)
>   create mode 100755 tests/qemu-iotests/306
>   create mode 100644 tests/qemu-iotests/306.out
>
Vladimir Sementsov-Ogievskiy Jan. 9, 2021, 10:11 a.m. UTC | #2
ping ping

18.12.2020 13:57, Vladimir Sementsov-Ogievskiy wrote:
> ping :)
> 
> 30.11.2020 16:40, Vladimir Sementsov-Ogievskiy wrote:
>> Hi all! There is a new feature: reconnect on open. It is useful when
>> start of vm and start of nbd server are not simple to sync.
>>
>> v2: rebase on master.
>> Also, I've discovered that I've sent downstream version of test which
>> doesn't work here. So, the test is rewritten (with appropriate
>> improvements of iotests.py)
>>
>> Vladimir Sementsov-Ogievskiy (8):
>>    block/nbd: move initial connect to coroutine
>>    nbd: allow reconnect on open, with corresponding new options
>>    iotests.py: fix qemu_tool_pipe_and_status()
>>    iotests.py: qemu_io(): reuse qemu_tool_pipe_and_status()
>>    iotests.py: add qemu_tool_popen()
>>    iotests.py: add and use qemu_io_wrap_args()
>>    iotests.py: add qemu_io_popen()
>>    iotests: add 306 to test reconnect on nbd open
>>
>>   block/nbd.c                   | 173 +++++++++++++++++++++++++---------
>>   tests/qemu-iotests/306        |  71 ++++++++++++++
>>   tests/qemu-iotests/306.out    |  11 +++
>>   tests/qemu-iotests/group      |   1 +
>>   tests/qemu-iotests/iotests.py |  56 +++++++----
>>   5 files changed, 246 insertions(+), 66 deletions(-)
>>   create mode 100755 tests/qemu-iotests/306
>>   create mode 100644 tests/qemu-iotests/306.out
>>
> 
>
Eric Blake Jan. 21, 2021, 2:17 a.m. UTC | #3
On 11/30/20 7:40 AM, Vladimir Sementsov-Ogievskiy wrote:
> Hi all! There is a new feature: reconnect on open. It is useful when
> start of vm and start of nbd server are not simple to sync.
> 
> v2: rebase on master.
> Also, I've discovered that I've sent downstream version of test which
> doesn't work here. So, the test is rewritten (with appropriate
> improvements of iotests.py)

Because of my questions on 2, I haven't queued the series yet; but 3 and
4 were independent enough to take now.

> 
> Vladimir Sementsov-Ogievskiy (8):
>   block/nbd: move initial connect to coroutine
>   nbd: allow reconnect on open, with corresponding new options
>   iotests.py: fix qemu_tool_pipe_and_status()
>   iotests.py: qemu_io(): reuse qemu_tool_pipe_and_status()
>   iotests.py: add qemu_tool_popen()
>   iotests.py: add and use qemu_io_wrap_args()
>   iotests.py: add qemu_io_popen()
>   iotests: add 306 to test reconnect on nbd open
> 
>  block/nbd.c                   | 173 +++++++++++++++++++++++++---------
>  tests/qemu-iotests/306        |  71 ++++++++++++++
>  tests/qemu-iotests/306.out    |  11 +++
>  tests/qemu-iotests/group      |   1 +
>  tests/qemu-iotests/iotests.py |  56 +++++++----
>  5 files changed, 246 insertions(+), 66 deletions(-)
>  create mode 100755 tests/qemu-iotests/306
>  create mode 100644 tests/qemu-iotests/306.out
>