Message ID | 20201027223003.166768-3-fdangelo@redhat.com |
---|---|
State | Changes Requested |
Headers | show |
Series | Incorporate fixes from lldpd upstream | expand |
Bleep bloop. Greetings Fabrizio D'Angelo, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Jonas Johansson <jonasj76@gmail.com> needs to sign off. WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Fabrizio D'Angelo <fdangelo@redhat.com> Lines checked: 35, Warnings: 1, Errors: 1 Please check this out. If you feel there has been an error, please email aconole@redhat.com Thanks, 0-day Robot
Fabrizio D'Angelo <fdangelo@redhat.com> writes: > From: Jonas Johansson <jonasj76@gmail.com> > > Upstream commit: > commit a8d8006c06d9ac16ebcf33295cbd625c0847ca9b > Author: Jonas Johansson <jonasj76@gmail.com> > Date: Thu, 21 Apr 2016 11:50:06 +0200 > > Fix size of PEEK_DISCARD_UINT32() > > Signed-off-by: Jonas Johansson <jonasj76@gmail.com> > > Signed-off-by: Fabrizio D'Angelo <fdangelo@redhat.com> > --- Acked-by: Aaron Conole <aconole@redhat.com>
diff --git a/lib/lldp/lldp.c b/lib/lldp/lldp.c index e61ce67746..593c5e1c34 100644 --- a/lib/lldp/lldp.c +++ b/lib/lldp/lldp.c @@ -59,7 +59,7 @@ VLOG_DEFINE_THIS_MODULE(lldp); } while (0) #define PEEK_DISCARD_UINT8 PEEK_DISCARD(1) #define PEEK_DISCARD_UINT16 PEEK_DISCARD(2) -#define PEEK_DISCARD_UINT32 PEEK_DISCARD(3) +#define PEEK_DISCARD_UINT32 PEEK_DISCARD(4) #define PEEK_CMP(value, bytes) \ (length -= (bytes), \ pos += (bytes), \