diff mbox series

[01/13] dt-bindings: arm: fsl: update TQ-Systems SoMs and boards based on i.MX7

Message ID 20200918112942.1367-1-matthias.schiffer@ew.tq-group.com
State Not Applicable, archived
Headers show
Series [01/13] dt-bindings: arm: fsl: update TQ-Systems SoMs and boards based on i.MX7 | expand

Checks

Context Check Description
robh/dt-meta-schema success
robh/checkpatch success

Commit Message

Matthias Schiffer Sept. 18, 2020, 11:29 a.m. UTC
Introduce compatible strings for the TQMa7x SoMs.

Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

Comments

Rob Herring (Arm) Sept. 23, 2020, 8:50 p.m. UTC | #1
On Fri, 18 Sep 2020 13:29:30 +0200, Matthias Schiffer wrote:
> Introduce compatible strings for the TQMa7x SoMs.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Matthias Schiffer Oct. 22, 2020, 10:46 a.m. UTC | #2
On Fri, 2020-09-18 at 13:29 +0200, Matthias Schiffer wrote:
> Introduce compatible strings for the TQMa7x SoMs.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>


Hello Shawn,

what is the status of this patch series? I've found the series marked
as "archived" in patchwork [1], but I can't find it in any public Git
repo. Am I looking at the wrong patchwork project?

Kind regards,
Matthias

[1] https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=351407&state=%2A&archive=both


> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 71acf14da715..d7233cef4d38 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -298,7 +298,12 @@ properties:
>                - toradex,colibri-imx7s           # Colibri iMX7 Solo Module
>                - toradex,colibri-imx7s-aster     # Colibri iMX7 Solo Module on Aster Carrier Board
>                - toradex,colibri-imx7s-eval-v3   # Colibri iMX7 Solo Module on Colibri Evaluation Board V3
> -              - tq,imx7s-mba7             # i.MX7S TQ MBa7 with TQMa7S SoM
> +          - const: fsl,imx7s
> +
> +      - description: TQ-Systems TQMa7S SoM on MBa7x board
> +        items:
> +          - const: tq,imx7s-mba7
> +          - const: tq,imx7s-tqma7
>            - const: fsl,imx7s
>  
>        - description: i.MX7D based Boards
> @@ -320,11 +325,16 @@ properties:
>                                                          #  Colibri Evaluation Board V3
>                - toradex,colibri-imx7d-eval-v3           # Colibri iMX7 Dual Module on
>                                                          #  Colibri Evaluation Board V3
> -              - tq,imx7d-mba7             # i.MX7D TQ MBa7 with TQMa7D SoM
>                - zii,imx7d-rmu2            # ZII RMU2 Board
>                - zii,imx7d-rpu2            # ZII RPU2 Board
>            - const: fsl,imx7d
>  
> +      - description: TQ-Systems TQMa7D SoM on MBa7x board
> +        items:
> +          - const: tq,imx7d-mba7
> +          - const: tq,imx7d-tqma7
> +          - const: fsl,imx7d
> +
>        - description:
>            Compulab SBC-iMX7 is a single board computer based on the
>            Freescale i.MX7 system-on-chip. SBC-iMX7 is implemented with
Shawn Guo Oct. 28, 2020, 7:38 a.m. UTC | #3
On Fri, Sep 18, 2020 at 01:29:31PM +0200, Matthias Schiffer wrote:
> The SPI-NOR flash on the SoM was missing from the device tree.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> ---
>  arch/arm/boot/dts/imx7-tqma7.dtsi | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx7-tqma7.dtsi b/arch/arm/boot/dts/imx7-tqma7.dtsi
> index 8773344b54aa..fd23f764399a 100644
> --- a/arch/arm/boot/dts/imx7-tqma7.dtsi
> +++ b/arch/arm/boot/dts/imx7-tqma7.dtsi
> @@ -160,6 +160,20 @@
>  		>;
>  	};
>  
> +	pinctrl_qspi: qspigrp {
> +		fsl,pins = <
> +			MX7D_PAD_EPDC_DATA00__QSPI_A_DATA0	0x5A
> +			MX7D_PAD_EPDC_DATA01__QSPI_A_DATA1	0x5A
> +			MX7D_PAD_EPDC_DATA02__QSPI_A_DATA2	0x5A
> +			MX7D_PAD_EPDC_DATA03__QSPI_A_DATA3	0x5A
> +			MX7D_PAD_EPDC_DATA05__QSPI_A_SCLK	0x11
> +			MX7D_PAD_EPDC_DATA06__QSPI_A_SS0_B	0x54
> +			MX7D_PAD_EPDC_DATA07__QSPI_A_SS1_B	0x54
> +			/* #QSPI_RESET */
> +			MX7D_PAD_EPDC_DATA04__GPIO2_IO4		0x40000052
> +		>;
> +	};
> +
>  	pinctrl_usdhc3: usdhc3grp {
>  		fsl,pins = <
>  			MX7D_PAD_SD3_CMD__SD3_CMD		0x59
> @@ -217,6 +231,22 @@
>  	};
>  };
>  
> +&qspi {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_qspi>;
> +	status = "okay";
> +
> +	flash0: spinor@0 {

The node name should be as generic as possible.  So suggest something
like 'flash@0'.

Shawn

> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		compatible = "jedec,spi-nor";
> +		spi-max-frequency = <29000000>;
> +		spi-rx-bus-width = <4>;
> +		spi-tx-bus-width = <4>;
> +		reg = <0>;
> +	};
> +};
> +
>  &sdma {
>  	status = "okay";
>  };
> -- 
> 2.17.1
>
Shawn Guo Oct. 28, 2020, 7:40 a.m. UTC | #4
On Fri, Sep 18, 2020 at 01:29:33PM +0200, Matthias Schiffer wrote:
> This property was never set correctly; it should have been num-cs. As
> num-cs support is being removed as well, simply drop it.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>

Applied, thanks.
Shawn Guo Oct. 28, 2020, 7:40 a.m. UTC | #5
On Fri, Sep 18, 2020 at 01:29:34PM +0200, Matthias Schiffer wrote:
> These properties were never supported by the DP83867, and a patch
> implementing them was rejected in favor of a different solution. Remove
> them.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>

Applied, thanks.
Shawn Guo Oct. 28, 2020, 7:41 a.m. UTC | #6
On Fri, Sep 18, 2020 at 01:29:35PM +0200, Matthias Schiffer wrote:
> The clock outputs are not connected. Disable them to improve EMI
> behaviour.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>

Applied, thanks.
Shawn Guo Oct. 28, 2020, 8:26 a.m. UTC | #7
On Fri, Sep 18, 2020 at 01:29:30PM +0200, Matthias Schiffer wrote:
> Introduce compatible strings for the TQMa7x SoMs.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>

Applied, thanks.
Shawn Guo Oct. 28, 2020, 8:27 a.m. UTC | #8
On Fri, Sep 18, 2020 at 01:29:36PM +0200, Matthias Schiffer wrote:
> The external watchdog reset is necessary, as the internal reset is
> unreliable on i.MX7.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>

Applied, thanks.
Shawn Guo Oct. 28, 2020, 8:28 a.m. UTC | #9
On Fri, Sep 18, 2020 at 01:29:37PM +0200, Matthias Schiffer wrote:
> Together with the recently merged support for alias-based MMC host
> numbering, this makes the MMC devices names match what the bootloader
> expects.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>

Applied, thanks.
Shawn Guo Oct. 28, 2020, 8:30 a.m. UTC | #10
On Fri, Sep 18, 2020 at 01:29:38PM +0200, Matthias Schiffer wrote:
> The MBa7x is equipped with a TI TLV320AIC3204 audio codec.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>

Applied, thanks.
Shawn Guo Oct. 28, 2020, 8:33 a.m. UTC | #11
On Fri, Sep 18, 2020 at 01:29:40PM +0200, Matthias Schiffer wrote:
> The UART7 interface is connected to a full-duplex RS485 transceiver.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>

Applied, thanks.
Shawn Guo Oct. 28, 2020, 8:34 a.m. UTC | #12
On Fri, Sep 18, 2020 at 01:29:41PM +0200, Matthias Schiffer wrote:
> Add over-current-active-low to usbotg1.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>

Applied, thanks.
Shawn Guo Oct. 28, 2020, 8:36 a.m. UTC | #13
On Fri, Sep 18, 2020 at 01:29:42PM +0200, Matthias Schiffer wrote:
> USBOTG1 has a Micro-USB port that can be used in host mode (using an OTG
> cable) or device mode.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>

Applied, thanks.
Shawn Guo Oct. 28, 2020, 8:36 a.m. UTC | #14
On Fri, Sep 18, 2020 at 01:29:32PM +0200, Matthias Schiffer wrote:
> Include the SoM compatible string.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 71acf14da715..d7233cef4d38 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -298,7 +298,12 @@  properties:
               - toradex,colibri-imx7s           # Colibri iMX7 Solo Module
               - toradex,colibri-imx7s-aster     # Colibri iMX7 Solo Module on Aster Carrier Board
               - toradex,colibri-imx7s-eval-v3   # Colibri iMX7 Solo Module on Colibri Evaluation Board V3
-              - tq,imx7s-mba7             # i.MX7S TQ MBa7 with TQMa7S SoM
+          - const: fsl,imx7s
+
+      - description: TQ-Systems TQMa7S SoM on MBa7x board
+        items:
+          - const: tq,imx7s-mba7
+          - const: tq,imx7s-tqma7
           - const: fsl,imx7s
 
       - description: i.MX7D based Boards
@@ -320,11 +325,16 @@  properties:
                                                         #  Colibri Evaluation Board V3
               - toradex,colibri-imx7d-eval-v3           # Colibri iMX7 Dual Module on
                                                         #  Colibri Evaluation Board V3
-              - tq,imx7d-mba7             # i.MX7D TQ MBa7 with TQMa7D SoM
               - zii,imx7d-rmu2            # ZII RMU2 Board
               - zii,imx7d-rpu2            # ZII RPU2 Board
           - const: fsl,imx7d
 
+      - description: TQ-Systems TQMa7D SoM on MBa7x board
+        items:
+          - const: tq,imx7d-mba7
+          - const: tq,imx7d-tqma7
+          - const: fsl,imx7d
+
       - description:
           Compulab SBC-iMX7 is a single board computer based on the
           Freescale i.MX7 system-on-chip. SBC-iMX7 is implemented with